Skip to content

Archive wg-traits and create types team #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

jackh726
Copy link
Member

Also, welcome @compiler-errors (officially).

Zulip and github things should be renamed before this is merged.

@rylev
Copy link
Member

rylev commented May 24, 2022

cc @wesleywiser and @pnkfelix since we'll want approval from the compiler team before merging.

The failure in CI is from here. We have a validation that all people in the Team repo are at least on one team. However, this does not take into account archived teams. I believe the right thing to do is to update this logic to all consider archived teams, but I'd like to check with @pietroalbini first.

@jackh726
Copy link
Member Author

Is the RFC not approval? And why compiler and not lang? (If it's because the labeled subteam, then it really should be both and this is just a limitation of the team repo)

Let me know if I need to make a PR to fix the archived team issue.

@rylev
Copy link
Member

rylev commented May 24, 2022

@jackh726 There is a lot of chance for things to happen in the meantime that could materially impact whether this should be merged or not. I think it's a safer to ensure that team leads are made aware when there is a membership change in their team or a related subteam.

The point about lang is a good one. cc @nikomatsakis @joshtriplett

wesleywiser
wesleywiser previously approved these changes May 24, 2022
@jackh726
Copy link
Member Author

Thoughts on me dropping wg-traits.toml from archive (or commenting out the members causing problems with a FIXME) to move this forward without blocking on fixing the archived teams check?

@pietroalbini
Copy link
Member

So, since what to do with archived teams is a bit of a bigger question what I'd do is keep the wg-traits team around but remove it from the website and all the actual permissions, ideally with a todo comment. That way we don't lose any data until we figure out what to do with archived teams.

@jackh726
Copy link
Member Author

jackh726 commented May 26, 2022

Okay, I can move it back to a regular team. Do I just remove the [[website]] section? (And permissions)

@pietroalbini
Copy link
Member

That, and also [[github]] and [permissions].

@jackh726
Copy link
Member Author

Updated for reviews

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd like us to address the one issue I found.

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nikomatsakis
Copy link
Contributor

This looks great, thanks @jackh726 for preparing it

@jackh726
Copy link
Member Author

Anything else that needs to be done for this to be merged?

@rylev rylev merged commit ec38272 into rust-lang:master May 27, 2022
@jackh726 jackh726 deleted the t-types branch May 27, 2022 18:38
@jackh726 jackh726 mentioned this pull request Sep 28, 2022
@rylev rylev mentioned this pull request Sep 29, 2022
@dtolnay dtolnay mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants