-
Notifications
You must be signed in to change notification settings - Fork 316
Archive wg-traits and create types team #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @wesleywiser and @pnkfelix since we'll want approval from the compiler team before merging. The failure in CI is from here. We have a validation that all people in the Team repo are at least on one team. However, this does not take into account archived teams. I believe the right thing to do is to update this logic to all consider archived teams, but I'd like to check with @pietroalbini first. |
Is the RFC not approval? And why compiler and not lang? (If it's because the labeled subteam, then it really should be both and this is just a limitation of the team repo) Let me know if I need to make a PR to fix the archived team issue. |
@jackh726 There is a lot of chance for things to happen in the meantime that could materially impact whether this should be merged or not. I think it's a safer to ensure that team leads are made aware when there is a membership change in their team or a related subteam. The point about lang is a good one. cc @nikomatsakis @joshtriplett |
Thoughts on me dropping |
So, since what to do with archived teams is a bit of a bigger question what I'd do is keep the wg-traits team around but remove it from the website and all the actual permissions, ideally with a todo comment. That way we don't lose any data until we figure out what to do with archived teams. |
Okay, I can move it back to a regular team. Do I just remove the |
That, and also |
Updated for reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I'd like us to address the one issue I found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This looks great, thanks @jackh726 for preparing it |
Anything else that needs to be done for this to be merged? |
Also, welcome @compiler-errors (officially).
Zulip and github things should be renamed before this is merged.