Avoid installing protoc for most CI workflows#3447
Merged
rbtcollins merged 2 commits intorust-lang:masterfrom Aug 17, 2023
Merged
Avoid installing protoc for most CI workflows#3447rbtcollins merged 2 commits intorust-lang:masterfrom
rbtcollins merged 2 commits intorust-lang:masterfrom
Conversation
It seems like it should only be needed for the all-features workflow, which enables `otel` via `--all-features`. Because we get rate-limited by something inside the setup-protoc Action, this is a fairly frequent source of spurious CI failures.
Contributor
Author
|
Seems to pass CI (macOS still going right now) except for the previously failing Linux armv7-unknown-linux-gnueabihf workflows. |
Contributor
|
I hadn't noticed rate limiting being at the heart of the failures - do you have an example we can refer to? |
rbtcollins
reviewed
Aug 16, 2023
| - name: Install Protoc | ||
| uses: arduino/setup-protoc@v1 | ||
| with: | ||
| version: '3.x' |
Contributor
There was a problem hiding this comment.
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
Seems like the canonical approach to avoid rate limiting, from the setup-protoc repo.
Contributor
Author
There was a problem hiding this comment.
Added this in another commit to all-features.yaml.
Member
@rbtcollins At least I can confirm that this is not uncommon: |
In order to avoid getting rate limited.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like it should only be needed for the
all-featuresworkflow, which enablesotelvia--all-features.Because we get rate-limited by something inside the setup-protoc Action, this is a fairly frequent source of spurious CI failures.
This was introduced in #3340 according to git blame.