Visual Studio 2019

[TjeuKayim]

Describe the problem you are trying to solve

Rustup prompts for installing the Microsoft C++ build tools on Windows. It refers to Visual Studio 2017, and links to https://aka.ms/buildtools. I noticed that this information is outdated.

On 2 April 2019, Visual Studio 2019 was released. The link https://aka.ms/buildtools is pointing to https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2017, but that anchor does not exist anymore.

https://github.com/rust-lang/rustup.rs/blob/8f1d93edbd037fbc849e72c7aef66a61146ee458/src/cli/self_update.rs#L175-L190

Describe the solution you'd like

The instructions printed by the CLI need an update. The help text should refer to Visual Studio 2019. Instructions to install 'Visual C++ Build Tools 2017' should be removed. It seems like the official downloads are no longer available.

Maybe the package manager chocolatey can be mentioned as an alternative to acquire the build-tools.

Notes
Steps to install build tools 2019:

1. Visit https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019
2. Download "Build Tools for Visual Studio 2019"
3. Start the installer and enable the checkbox "C++ build tools"
4. Run rustup-init.exe

I verified this process on a clean Windows 10 machine. Afterwards Cargo runs successfully.

Screenshot of Visual Studio 2019 installer:

[TjeuKayim]

I just noticed that the content at 'https://www.rust-lang.org/tools/install' is already updated for Visual Studio 2019.
rust-lang/www.rust-lang.org#736

Could you please have a look at this @yoshuawuyts?

I searched the Github oranisation rust-lang for "Visual Studio 2017", to find that the Rust Book also needs an update.
rust-lang/book#1923

[yoshuawuyts]

@TjeuKayim thanks for the ping and raising this! -- I don't maintain rustup, but I'm sure someone from the tools team will be able to help with this soon!

[kinnison]

@TjeuKayim Thanks for the issue, and the PR. I've asked on the PR for you to also update our README.md appropriately so that the two parts are not contradicting one another.

[TjeuKayim]

Thank you for merging!

[soernt]

As with Visual Studio 2019 installer 2.10.217... there is not even a workload named "C++ build tools" only "Desktop development with c++". Even at the tab "Single Components" there as not a single option "c++ build tools" but a large list of "c++ XXX" options. So I am total confused what exactly needs to be installed. I guess that is the option I selected within the screenshot. It would be helpful to update the documentation.

[kinnison]

@rbtcollins What do you say? If the docs/recommendation text needs updating let's get it as right as we can.

[mgrandi]

so i can confirm that i think the necessary category that worked for me is "Desktop Development with C++", however that might be too big of a category, not sure