Skip to content

Update outdated reference to ty::Predicate #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2020
Merged

Update outdated reference to ty::Predicate #711

merged 1 commit into from
May 23, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

Since rust-lang/rust#72055, Predicate is no longer a enum alias to PredicateKind, but is a struct containing a PredicateKind. Should we point to PredicateKind instead?

This was referenced May 23, 2020
Merged
Merged
mark-i-m
mark-i-m approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is reasonable, and AFAICT still expresses the intended meaning in the preceding para

@mark-i-m mark-i-m merged commit 59c9fa7 into master May 23, 2020
@mark-i-m mark-i-m deleted the LeSeulArtichaut-patch-1 branch May 23, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mark-i-m mark-i-m mark-i-m approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeSeulArtichaut @mark-i-m