Skip to content

Conversation

@jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 16, 2021

This was added in rust-lang/rust#81064 (and shouldn't be merged until after that PR is merged).

@jyn514 jyn514 added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Jan 16, 2021
@jyn514 jyn514 changed the title Note that --check now allows using any stage Note that x.py check now allows using any stage Jan 16, 2021
@LeSeulArtichaut LeSeulArtichaut added the S-blocked Status: this PR is blocked waiting for something label Jan 16, 2021
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tshepang tshepang merged commit 176bbba into rust-lang:master Jan 17, 2021
@jyn514 jyn514 deleted the check branch January 17, 2021 03:53
@jyn514
Copy link
Member Author

jyn514 commented Jan 17, 2021

@tshepang this should not have been merged yet. check --stage 1 has not been merged into master.

@jyn514 jyn514 restored the check branch January 17, 2021 03:54
@tshepang
Copy link
Member

ok, was too quick... saw approval and assumed it was merged already

@jyn514
Copy link
Member Author

jyn514 commented Jan 17, 2021

No worries, it was just merged :)

@jyn514 jyn514 deleted the check branch January 17, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blocked Status: this PR is blocked waiting for something S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants