Skip to content

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Apr 28, 2022

Similar to #96508, this switches NetBSD to our futex-based locks and thread parker, using NetBSD's futex syscall.

This is a draft, because this still needs a new version of the libc crate to be published.

@m-ou-se m-ou-se added A-concurrency Area: Concurrency O-netbsd Operating system: NetBSD S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 28, 2022
@rust-highfive

This comment was marked as off-topic.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2022
@m-ou-se m-ou-se marked this pull request as draft April 28, 2022 09:06
@m-ou-se
Copy link
Member Author

m-ou-se commented Apr 28, 2022

I'll combine the BSDs into a single PR.

@m-ou-se m-ou-se closed this Apr 28, 2022
@m-ou-se m-ou-se deleted the futex-netbsd branch April 28, 2022 09:20
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Successfully built fda035b1b83c
Successfully tagged rust-ci:latest
Built container sha256:fda035b1b83cd5f6805d0bcad8fc6a869bee24a5e432abf6d70a056c37131880
Uploading finished image to https://ci-caches.rust-lang.org/docker/c165c0dbe07f979c65839814f65d46fc3b20640fec5c6162fa0d12eccd662a5501f008e9d9c1953dc5ee940f259fa67db4f7e378e34b63c10ab0f0e1d88ab56a
upload failed: - to s3://rust-lang-ci-sccache2/docker/c165c0dbe07f979c65839814f65d46fc3b20640fec5c6162fa0d12eccd662a5501f008e9d9c1953dc5ee940f259fa67db4f7e378e34b63c10ab0f0e1d88ab56a Unable to locate credentials
[CI_JOB_NAME=mingw-check]
---
   Compiling cc v1.0.69
    Checking core v0.0.0 (/checkout/library/core)
   Compiling libc v0.2.121
   Compiling memchr v2.4.1
   Compiling libc v0.2.124 (https://github.com/rust-lang/libc#f6df53fd)
   Compiling compiler_builtins v0.1.71
   Compiling unwind v0.0.0 (/checkout/library/unwind)
    Checking rustc-std-workspace-core v1.99.0 (/checkout/library/rustc-std-workspace-core)
    Checking alloc v0.0.0 (/checkout/library/alloc)
---
configure: rust.debug-assertions := True
configure: rust.overflow-checks := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
   Compiling cc v1.0.69
    Checking core v0.0.0 (/checkout/library/core)
   Compiling libc v0.2.121
   Compiling memchr v2.4.1
   Compiling libc v0.2.124 (https://github.com/rust-lang/libc#f6df53fd)
   Compiling compiler_builtins v0.1.71
   Compiling unwind v0.0.0 (/checkout/library/unwind)
    Checking rustc-std-workspace-core v1.99.0 (/checkout/library/rustc-std-workspace-core)
    Checking alloc v0.0.0 (/checkout/library/alloc)
---
   Compiling cc v1.0.69
   Compiling core v0.0.0 (/checkout/library/core)
   Compiling libc v0.2.121
   Compiling memchr v2.4.1
   Compiling libc v0.2.124 (https://github.com/rust-lang/libc#f6df53fd)
   Compiling compiler_builtins v0.1.71
   Compiling unwind v0.0.0 (/checkout/library/unwind)
   Compiling rustc-std-workspace-core v1.99.0 (/checkout/library/rustc-std-workspace-core)
   Compiling alloc v0.0.0 (/checkout/library/alloc)
---
   Compiling regex v1.5.5
   Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
    Finished release [optimized] target(s) in 9.18s
tidy check
tidy error: invalid source: "git+https://github.com/rust-lang/libc#f6df53fd694f6fc903058c765efc10d77725b31b"
Checking which error codes lack tests...
* 629 error codes
* highest error code: E0787
Found 504 error codes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-concurrency Area: Concurrency O-netbsd Operating system: NetBSD S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants