Skip to content

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Feb 4, 2021

No description provided.

@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 4, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 4, 2021
@bors
Copy link
Collaborator

bors commented Feb 4, 2021

⌛ Trying commit a6742ae35c19722e4dc2309461b24328926e106d with merge d589fc7d554c7ecdab26eb7ae07fd6dc7e8280f7...

@bors
Copy link
Collaborator

bors commented Feb 4, 2021

☀️ Try build successful - checks-actions
Build commit: d589fc7d554c7ecdab26eb7ae07fd6dc7e8280f7 (d589fc7d554c7ecdab26eb7ae07fd6dc7e8280f7)

@rust-timer
Copy link
Collaborator

Queued d589fc7d554c7ecdab26eb7ae07fd6dc7e8280f7 with parent 822ebfd, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (d589fc7d554c7ecdab26eb7ae07fd6dc7e8280f7): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 5, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 5, 2021

Before:

let mut debug_trait_builder = ::core::fmt::Formatter::debug_struct(f, "S");
let _ = ::core::fmt::DebugStruct::field(&mut debug_trait_builder, "a", &&(*__self_0_0));
...
::core::fmt::DebugStruct::finish(&mut debug_trait_builder)

After:

let debug_trait_builder = &mut ::core::fmt::Formatter::debug_struct(f, "S");
let _ = ::core::fmt::DebugStruct::field(debug_trait_builder, "a", &&(*__self_0_0));
...
::core::fmt::DebugStruct::finish(debug_trait_builder)

For each call to a debug builder, this implementation reduces the number of temporaries by one and the number of statements by three at MIR level.

r? @pnkfelix

@pnkfelix
Copy link
Contributor

@bors r+ rollup=never

(the results seem acceptable, but I dont want to roll them up so that they don't mask effects of other PRs)

@bors
Copy link
Collaborator

bors commented Feb 10, 2021

📌 Commit a6742ae35c19722e4dc2309461b24328926e106d has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2021
@bors
Copy link
Collaborator

bors commented Feb 10, 2021

⌛ Testing commit a6742ae35c19722e4dc2309461b24328926e106d with merge 917f4e66d59ebcae548077514552190b3e5d0895...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Feb 10, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 10, 2021

Updated test output.

@pnkfelix
Copy link
Contributor

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Feb 11, 2021

📌 Commit 1cf9505 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2021
@bors
Copy link
Collaborator

bors commented Feb 11, 2021

⌛ Testing commit 1cf9505 with merge e9920ef...

@bors
Copy link
Collaborator

bors commented Feb 11, 2021

☀️ Test successful - checks-actions
Approved by: pnkfelix
Pushing e9920ef to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 11, 2021
@bors bors merged commit e9920ef into rust-lang:master Feb 11, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 11, 2021
@tmiasko tmiasko deleted the debug-borrow branch February 11, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants