Skip to content

Remove deprecated unstable Vec::resize_default #77850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2020
Merged

Remove deprecated unstable Vec::resize_default #77850

merged 1 commit into from
Oct 16, 2020

Conversation

kornelski
Copy link
Contributor

@kornelski kornelski commented Oct 12, 2020 •
edited
Loading

It's been deprecated for 15 releases.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2020
pickfire
pickfire approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But I wonder if we have a timeline where we say it could deprecate after N release?

@Mark-Simulacrum
Copy link
Member

I don't think we need fcp on this, but I would like a @rust-lang/libs member to sign-off on this, so let's r? @dtolnay perhaps?

@jyn514 jyn514 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. requires-nightly This issue requires a nightly compiler in some way. labels Oct 12, 2020
dtolnay
dtolnay approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Oct 15, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 15, 2020

📌 Commit 07637db has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2020
@bors
Copy link
Collaborator

bors commented Oct 16, 2020

⌛ Testing commit 07637db with merge 8850893...

@bors
Copy link
Collaborator

bors commented Oct 16, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: dtolnay
Pushing 8850893 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 16, 2020
@bors bors merged commit 8850893 into rust-lang:master Oct 16, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 16, 2020
@kornelski kornelski deleted the resizedefault branch October 16, 2020 19:44
@steffahn
Copy link
Member

steffahn commented Dec 28, 2021 •
edited
Loading

ExtendDefault is unused now (presumably after this PR)

@steffahn steffahn mentioned this pull request Jan 6, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 6, 2022
@matthiaskrgr
Rollup merge of rust-lang#92620 - steffahn:remove_unused_ExtendDefaul…
db056e9 
…t_struct, r=Mark-Simulacrum

Remove unused `ExtendDefault` struct

As noted in rust-lang#77850 (comment), this struct is no longer used.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 6, 2022
@matthiaskrgr
Rollup merge of rust-lang#92620 - steffahn:remove_unused_ExtendDefaul…
fcae1d6 
…t_struct, r=Mark-Simulacrum

Remove unused `ExtendDefault` struct

As noted in rust-lang#77850 (comment), this struct is no longer used.
@dtolnay dtolnay mentioned this pull request Sep 13, 2022
Closed
4 tasks
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 18, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

+1 more reviewer

@pickfire pickfire pickfire approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dtolnay dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors. requires-nightly This issue requires a nightly compiler in some way. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
9 participants
@kornelski @rust-highfive @Mark-Simulacrum @dtolnay @bors @steffahn @pickfire @jyn514 @rustbot