Skip to content

Conversation

GuillaumeGomez
Copy link
Member

There was a slight color difference in the theme choice menu borders:

Screenshot from 2020-08-24 10-37-05
Screenshot from 2020-08-24 10-37-58

r? @Cldfire

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I wish there is more x padding.

@GuillaumeGomez
Copy link
Member Author

That's another debate. :)

@bors: r=pickfire rollup

@bors
Copy link
Collaborator

bors commented Aug 24, 2020

📌 Commit efef159 has been approved by pickfire

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 24, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2020
Rollup of 10 pull requests

Successful merges:

 - rust-lang#74730 (Hexagon libstd: update type defs)
 - rust-lang#75758 (Fixes for VxWorks)
 - rust-lang#75780 (Unconfuse Unpin docs a bit)
 - rust-lang#75806 (Prevent automatic page change when using history)
 - rust-lang#75818 (Update docs for SystemTime Windows implementation)
 - rust-lang#75837 (Fix font color for help button in ayu and dark themes)
 - rust-lang#75870 (Unify theme choices border color in ayu theme)
 - rust-lang#75875 (Shorten liballoc vec resize intra-doc link)
 - rust-lang#75953 (Fix swapped stability attributes for rustdoc lints)
 - rust-lang#75958 (Avoid function-scoping global variables)

Failed merges:

r? @ghost
@bors bors merged commit c1cb46e into rust-lang:master Aug 27, 2020
@GuillaumeGomez GuillaumeGomez deleted the unify-border-color-theme-ayu branch August 27, 2020 08:55
@cuviper cuviper added this to the 1.48.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants