Use new dataflow framework for generators #69295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
ecstatic-morse
force-pushed
the
unified-dataflow-generators
branch
from
2d2637a to
5b89e0a
Compare
|
Ping @tmandry |
This comment has been minimized.
This comment has been minimized.
This is more ergonomic than importing `dataflow::visit_results`
...to be consistent with the naming of other dataflow analyses.
ecstatic-morse
force-pushed
the
unified-dataflow-generators
branch
from
5b89e0a to
75d256f
Compare
tmandry
approved these changes
Feb 29, 2020
|
@bors r=tmandry |
|
📌 Commit dd69017f3f9a0e8e76ac6cfbfe8029250bf87270 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Reverse post-order requires an allocation.
ecstatic-morse
force-pushed
the
unified-dataflow-generators
branch
from
dd69017 to
21cd1fe
Compare
|
Ugh, that was a bit loose. @bors r=tmandry |
|
📌 Commit 21cd1fe has been approved by |
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#65672 introduced a new dataflow framework that can handle arbitrarily complex transfer functions as well as ones expressed as a series of gen/kill operations. This PR ports the analyses used to implement generators to the new framework so that we can remove the old one. See #68241 for a prior example of this. The new framework has some superficial API changes, but this shouldn't alter the generator passes in any way.
r? @tmandry