-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Add impl AddAssign<char> for Cow<'_, str>
#66215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
76a3b55
Added AddAssign<char> implementation for String
Ruster-a11y ed52372
Amended with the suggested syntax+improvements
Ruster-a11y 342277f
Ammended further to accomodate `AddAssign<char>` for `String` and `Co…
Ruster-a11y 9b55f6b
Added tests for the respective AddAssign/Add operations for `char` co…
Ruster-a11y cd2ad6d
Re-implemented so that Cow::Borrowed now gets allocated using the inh…
Ruster-a11y 12a32e6
Replaced wrongly used s.len() with lhs.len()
Ruster-a11y 543a0b6
Added String::reserve_exact() to reserve the optimal space.
Ruster-a11y ea5f056
Changed code logic to call RawVec::amortized_new_size() from prealloc…
Ruster-a11y 7d87504
Allocate new string using inline amortized logic.
Ruster-a11y d62e867
Revert "Added tests for the respective AddAssign/Add operations for `…
Ruster-a11y f2ac395
Revert "Ammended further to accomodate `AddAssign<char>` for `String`…
Ruster-a11y 0704d9b
Revert "Ammended further to accomodate `AddAssign<char>` for `String`…
Ruster-a11y 5623044
Revert to the start of PR
Ruster-a11y 5d2184b
impl Add<char> and AddAssign<char> for Cow<'_, str>
Ruster-a11y 47d0179
Fixed unused variable error in tests\cow_str.rs
Ruster-a11y File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.