Skip to content

bump stdsimd; make intra_doc_link_resolution_failure an error again; make lints more consistent #59955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2019
Merged

bump stdsimd; make intra_doc_link_resolution_failure an error again; make lints more consistent #59955

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdf1d36
bump stdsimd; make intra_doc_link_resolution_failure an error again
RalfJung Apr 14, 2019
8ef7ca1
make lint levels more consistent
RalfJung Apr 14, 2019
50c615b
warn(missing_docs) in liballoc, and add missing docs
RalfJung Apr 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/liballoc/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@
#![allow(explicit_outlives_requirements)]

#![warn(deprecated_in_future)]
#![warn(intra_doc_link_resolution_failure)]
#![warn(missing_debug_implementations)]
#![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings

#![cfg_attr(not(test), feature(generator_trait))]
#![cfg_attr(test, feature(test))]
Expand Down
2 changes: 1 addition & 1 deletion src/libcore/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@

#![warn(deprecated_in_future)]
#![warn(missing_docs)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw @alexcrichton is there any reason liballoc does not have warn(missing_docs)? Should I add it there as well to make things more consistent?

The other inconsistency I noticed is that libcore does not have deny(rust_2018_idioms). But that seems people just didn't get there yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is being worked on, #58702.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RalfJung when those annotations were added it wasn't needed, now that it's a stable crate we probably need it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I added the attribute. That uncovered a few missing docs, and indeed for items that got reexported in std! So I also added docs.

#![warn(intra_doc_link_resolution_failure)]
#![warn(missing_debug_implementations)]
#![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings

#![feature(allow_internal_unstable)]
#![feature(arbitrary_self_types)]
Expand Down
2 changes: 1 addition & 1 deletion src/stdsimd
Open in desktop
Submodule stdsimd updated from 2792b4 to 2323a8