-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Make core::mem::MaybeUninit::zeroed a const fn #54832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
0b6a44c
255f723
b18f946
fde2e91
e5eb54c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,6 +150,9 @@ impl<'a, 'mir, 'tcx, M: Machine<'a, 'mir, 'tcx>> EvalContext<'a, 'mir, 'tcx, M> | |
} | ||
self.write_scalar(val, dest)?; | ||
} | ||
"init" => { | ||
self.force_allocation(dest)?; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can just copy the implementation from https://github.com/solson/miri/blob/master/src/intrinsic.rs#L238 Your current implementation is a nop, it literally does nothing ;) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dang, that was awfully naive of me ha. Done. Side question: is there any reason that entire file isn't just copied into here? |
||
} | ||
"transmute" => { | ||
// Go through an allocation, to make sure the completely different layouts | ||
// do not pose a problem. (When the user transmutes through a union, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
#![feature(maybe_uninit)] | ||
|
||
use std::mem; | ||
|
||
fn main() { | ||
const UNIT: mem::MaybeUninit<()> = mem::MaybeUninit::zeroed(); | ||
let bytes: [u8; 0] = unsafe { mem::transmute(UNIT) }; | ||
assert_eq!(bytes, [0u8; 0]); | ||
|
||
const STRING: mem::MaybeUninit<String> = mem::MaybeUninit::zeroed(); | ||
let bytes: [u8; mem::size_of::<String>()] = unsafe { mem::transmute(STRING) }; | ||
assert_eq!(bytes, [0u8; mem::size_of::<String>()]); | ||
|
||
const U8: mem::MaybeUninit<u8> = mem::MaybeUninit::zeroed(); | ||
let bytes: [u8; 1] = unsafe { mem::transmute(U8) }; | ||
assert_eq!(bytes, [0u8; 1]); | ||
} |
Uh oh!
There was an error while loading. Please reload this page.