Add a note about overflow for fetch_add/fetch_sub #40927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also changed some other docs:
|
steveklabnik
added
the
T-libs-api
|
The doc changes look good to me. However, let's @rfcbot : fcp merge for libs, to make sure this is the behavior they want specc'd Oh wait, that doesn't work because I'm not on @rust-lang/libs |
|
cc @alexcrichton |
|
@bors: r+ Yeah these are the intended semantics |
|
📌 Commit 2946c41 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 2, 2017
… r=alexcrichton Add a note about overflow for fetch_add/fetch_sub Fixes rust-lang#40916 r? @steveklabnik
bors
added a commit
that referenced
this pull request
Apr 2, 2017
…hton Add a note about overflow for fetch_add/fetch_sub Fixes #40916 Fixes #34618 r? @steveklabnik
|
💔 Test failed - status-travis |
|
@bors: retry
* builder timed out :(
…On Sun, Apr 2, 2017 at 10:30 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/217781114>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40927 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95O0uM6MIOMceZjpcLvVfCw6PDZOZks5rr80ugaJpZM4MuawK>
.
|
|
⌛ Testing commit 2946c41 with merge a2c3aa7... |
|
💔 Test failed - status-travis |
|
@bors: retry something went wrong and the job took too long |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 3, 2017
… r=alexcrichton Add a note about overflow for fetch_add/fetch_sub Fixes rust-lang#40916 Fixes rust-lang#34618 r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 3, 2017
… r=alexcrichton Add a note about overflow for fetch_add/fetch_sub Fixes rust-lang#40916 Fixes rust-lang#34618 r? @steveklabnik
|
⌛ Testing commit 2946c41 with merge 93636b1... |
|
💔 Test failed - status-travis |
|
… On Mon, Apr 3, 2017 at 2:20 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/218215215>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40927 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95M_mXNRePQdiGCpMn5WSV-v0y8kTks5rsVR6gaJpZM4MuawK>
.
|
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Apr 5, 2017
… r=alexcrichton Add a note about overflow for fetch_add/fetch_sub Fixes rust-lang#40916 Fixes rust-lang#34618 r? @steveklabnik
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40916
Fixes #34618
r? @steveklabnik