Optimise Chars::last() #37882
Merged
Optimise Chars::last() #37882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default implementation of last() goes through the entire iterator but that's not needed here.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ rollup Thank you! |
|
📌 Commit de2f617 has been approved by |
|
By the way, this applies to char_indices as well. Another commit or another PR is welcome. |
The default implementation of last() goes through the entire iterator but that's not needed here.
|
Good point. I've applied the same to |
|
@bors r+ rollup |
|
📌 Commit 9e86e18 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 20, 2016
Optimise Chars::last() The default implementation of last() goes through the entire iterator but that's not needed here.
bors
added a commit
that referenced
this pull request
Nov 20, 2016
brson
added
the
relnotes
|
Shouldn't this apply to any |
|
Yeah, but I think it might be breaking change to do this for iterators that might have side effects. |
|
Yes. Iterator::last's doc is specific about how it goes about finding the last value (traversing it all). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation of last() goes through the entire iterator
but that's not needed here.