save-analysis: handle << and >> operators inside [] in types #37776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit e003d05 has been approved by |
| prev.tok.is_ident() { | ||
| result = Some(prev.sp); | ||
| } | ||
|
|
||
| if bracket_count == 0 { |
There was a problem hiding this comment.
So, this is a bit obscure. It seems like some comments might help to clarify what's going on.
| // Issue #37700 | ||
| const LUT_BITS: usize = 3; | ||
| pub struct HuffmanTable { | ||
| ac_lut: Option<[(i16, u8); 1 << LUT_BITS]>, |
There was a problem hiding this comment.
I don't really get what the logic is above, but I am wondering if it is going to work for something like Option<[u8; foo(X > Y)]> (where foo() is a const fn)?
There was a problem hiding this comment.
yeah it should do, that is kind of the point - this basically ignores any angle bracket-like tokens which occur inside [ ... ] because they could be part of expressions.
nrc
force-pushed
the
save-double-angle
branch
from
e003d05 to
8a949df
Compare
|
📌 Commit 8a949df has been approved by |
bors
added a commit
that referenced
this pull request
Nov 18, 2016
save-analysis: handle << and >> operators inside [] in types Fixes #37700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37700