Skip to content

Conversation

srinivasreddy
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@srinivasreddy
Copy link
Contributor Author

@arielb1 LGTM. What do you think?

} else {
'_'
})
.collect();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrc @ubsan This looks harder to read.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is probably the trickiest corner of formatting at the moment - I prefer visual indent for method chains, but it makes closures either ugly or subject to extreme rightward drift.

@srinivasreddy
Copy link
Contributor Author

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned arielb1 Oct 28, 2016
@bors
Copy link
Collaborator

bors commented Oct 31, 2016

☔ The latest upstream changes (presumably #37439) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Nov 3, 2016

☔ The latest upstream changes (presumably #37540) made this pull request unmergeable. Please resolve the merge conflicts.

@nrc
Copy link
Member

nrc commented Nov 7, 2016

r = me with a rebase

@frewsxcv
Copy link
Contributor

Closing due to inactivity. @srinivasreddy If you're still interested in these changes, let me know and I can reopen, otherwise you could just open a new PR.

@frewsxcv frewsxcv closed this Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants