Skip to content

Clarify type declaration language in Associated Types docs #35595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2016
Merged

Clarify type declaration language in Associated Types docs #35595

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed052d
Clarify type declaration language
urschrei Aug 11, 2016
31da7f6
More clarification
urschrei Aug 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/doc/book/associated-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ trait Graph {
Simple enough. Associated types use the `type` keyword, and go inside the body
of the trait, with the functions.

These `type` declarations can have all the same thing as functions do. For example,
These `type` declarations work in the same way as those for functions do. For example,
if we wanted our `N` type to implement `Display`, so we can print the nodes out,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would:

These type declarations work the same way as those for functions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would:

These type declarations work in the same way as they do for functions.

Thoughts, both of you? The original sentence is very bad :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @tshepang's version is clearer (I assumed the original was just written late at night / in a state of exhaustion)

we could do this:

Expand Down