Include type name in symbol for methods #30328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 8740575 with merge 9144a9c... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors retry |
|
⌛ Testing commit 8740575 with merge 26eb62f... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Dec 14, 2015
|
Nice! 🎈 |
| Impl => { | ||
| InternedString::new("<impl>") | ||
| } | ||
|
|
There was a problem hiding this comment.
I was hoping this could be combined with the actual type info to produce the full name.
Right now, the ast::Item name for impls is a hacky composition of the pretty-printed AST type and trait and I wish we could get rid of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30260.