Re-word UB in unsafe guide #26853
Merged
Re-word UB in unsafe guide #26853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -33,9 +33,21 @@ in the sections marked `unsafe`. | |||
|
|
|||
| # What does ‘safe’ mean? | |||
|
|
|||
| Safe, in the context of Rust, means “doesn’t do anything unsafe.” Easy! | |||
| Safe, in the context of Rust, means ‘doesn’t do anything unsafe’. It’s also | |||
| important to notice all kinds of behaviors that are certainly bad, but are | |||
There was a problem hiding this comment.
s/all kinds/there are kinds/ ?
There was a problem hiding this comment.
updated, let me know what you think :)
This incorrectly implied that doing things is fine in unsafe code Fixes rust-lang#26346
|
@bors r+ Thanks! |
|
📌 Commit bc28e64 has been approved by |
|
@bors: rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 7, 2015
This incorrectly implied that doing things is fine in unsafe code Fixes rust-lang#26346
bors
added a commit
that referenced
this pull request
Jul 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorrectly implied that doing things is fine in unsafe code
Fixes #26346