Skip to content

Leave lld on beta a little bit more #145755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: beta
Choose a base branch
from
Draft

Leave lld on beta a little bit more #145755

wants to merge 2 commits into from

Conversation

lqd
Copy link
Member

@lqd lqd commented Aug 22, 2025

r? @Kobzol

As discussed, this leaves lld on beta a bit more, to allow for a longer period of testing:

  • beta isn't used for testing all that much
  • it's summer for the northern hemisphere, activity is low, people are on vacation rather than testing the linker on beta
  • we'll advertise this for a longer call for testing on blog.rlo (as soon as I finish the blog post)

(opening as draft as I wonder what tests we can make CI do to check the combination of tests.)

try-job: x86_64-gnu-stable
try-job: dist-x86_64-linux
try-job: x86_64-gnu

lqd added 2 commits August 22, 2025 15:49
- stable tests to ensure lld is not used
- splitting beta (where lld is on) behavior from stable (where it is
  off)
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 22, 2025
@Mark-Simulacrum
Copy link
Member

As discussed

Oh, so we should drop 1.90 release notes + blog mentioning this? We hadn't found much else to talk about in 1.90, so will need to do some digging...

cc @rust-lang/release

@Noratrieb
Copy link
Member

Do we really expect any meaningful feedback within the next 6 weeks from it being on beta? I have doubts that this will really have that effect, but I'll leave it to you to have the final call of course.
Have we gotten any feedback about LLD in the last few months? Statically, nightly gets a lot more testing from people than beta.

@lqd
Copy link
Member Author

lqd commented Aug 22, 2025

I forgot to mention something: I'm not up-to-date on the discussion about the used(linker) changes and their impact (on RfL?), and the current nostart-stop-gc handling (or the lack thereof) relies on it to make linkme work.

Do we really expect any meaningful feedback within the next 6 weeks from it being on beta?

I'm not sure. Maybe not as-is, but with a dedicated blog post motivating people to test their stuff on beta?

@Hoverbear
Copy link
Contributor

Hoverbear commented Aug 22, 2025

On Ferrocene, we actually require folks to use rust-lld and have not experienced problems with LLD. We recently noticed some of our past releases were impacted by the previous change which limited lld to non-stable which requires us to notify our users how to workaround it. We were excited by #140525 since it meant we didn't have to carry a patch for this.

@practicalrs
Copy link
Contributor

I'm using nightly for running tests in the project just to use lld. It speeds up things for me. For the past 5 months, I have not seen any problems with it.

@Kobzol
Copy link
Member

Kobzol commented Aug 22, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Aug 22, 2025
Leave lld on beta a little bit more

try-job: x86_64-gnu-stable
try-job: dist-x86_64-linux
try-job: x86_64-gnu
@rust-bors

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Aug 22, 2025

☀️ Try build successful (CI)
Build commit: b366d25 (b366d2547fd54b0afbb8b4e90598b229596f9acb, parent: 085bdc2aee2772c4f392a8afcd5421a8e8b6e9e4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants