Skip to content

Correctly handle when there are no unstable items in the documented crate #145349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

Correctly handle when there are no unstable items in the documented crate #145349

merged 1 commit into from
Aug 13, 2025

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Aug 13, 2025 •
edited by rustbot
Loading

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 13, 2025
Closed
@fmease
Copy link
Member

fmease commented Aug 13, 2025 •
edited
Loading

Just curious, is there any more minimal way to reproduce the bug locally?

@GuillaumeGomez
Copy link
Member Author

I couldn't find one. It's very frustrating.

@fmease
Copy link
Member

fmease commented Aug 13, 2025 •
edited
Loading

I'm wondering if it would be something like "document crate X with an old rustdoc version, then redocument it with a new rustdoc version" in a such way that the generated *.js files in doc/ aren't overwritten. Of course, we would never be able to turn this into a test.

@GuillaumeGomez
Copy link
Member Author

We always link to the right JS files, so I don't think it would trigger it (just tested and I confirm it didn't).

@GuillaumeGomez
Copy link
Member Author

@bors r=lolbinarycat,fmease rollup

@bors
Copy link
Collaborator

bors commented Aug 13, 2025

📌 Commit cd79c71 has been approved by lolbinarycat,fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 13, 2025
@GuillaumeGomez
Rollup merge of rust-lang#145349 - GuillaumeGomez:unstable-items-sear…
f66f868 
…ch, r=lolbinarycat,fmease

Correctly handle when there are no unstable items in the documented crate

Fixes rust-lang#145287.

cc `@lolbinarycat`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 13, 2025
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 13, 2025
@GuillaumeGomez
Rollup merge of rust-lang#145349 - GuillaumeGomez:unstable-items-sear…
e7300e8 
…ch, r=lolbinarycat,fmease

Correctly handle when there are no unstable items in the documented crate

Fixes rust-lang#145287.

cc ``@lolbinarycat``
This was referenced Aug 13, 2025
Closed
Merged
bors added a commit that referenced this pull request Aug 13, 2025
@bors
Auto merge of #145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez
3672a55 
Rollup of 9 pull requests

Successful merges:

 - #144761 (aarch64: Make `outline-atomics` a known target feature)
 - #144949 (More `Printer` cleanups)
 - #144955 (search graph: lazily update parent goals)
 - #144962 (Add aarch64_be-unknown-none-softfloat target)
 - #145153 (Handle macros with multiple kinds, and improve errors)
 - #145241 ([AVR] Changed data_layout)
 - #145341 (Install libgccjit into the compiler's sysroot when cg_gcc is enabled)
 - #145349 (Correctly handle when there are no unstable items in the documented crate)
 - #145356 (Add another example for escaped `#` character in doctest in rustdoc book)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 858927c into rust-lang:master Aug 13, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 13, 2025
rust-timer added a commit that referenced this pull request Aug 13, 2025
@rust-timer
Unrolled build for #145349
ace7b01 
Rollup merge of #145349 - GuillaumeGomez:unstable-items-search, r=lolbinarycat,fmease

Correctly handle when there are no unstable items in the documented crate

Fixes #145287.

cc ```@lolbinarycat```
@GuillaumeGomez GuillaumeGomez deleted the unstable-items-search branch August 14, 2025 09:05
This was referenced Aug 14, 2025
Closed
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 14, 2025
@GuillaumeGomez
Rollup merge of rust-lang#145389 - GuillaumeGomez:unstable-search, r=…
d105953 
…fmease

[rustdoc] Revert "rustdoc search: prefer stable items in search results"

Reverts rust-lang#141658 and reverts rust-lang#145349.

Reopens rust-lang#138067.

r? `@fmease`
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 15, 2025
@Zalathar
Rollup merge of rust-lang#145389 - GuillaumeGomez:unstable-search, r=…
8677b73 
…fmease

[rustdoc] Revert "rustdoc search: prefer stable items in search results"

Reverts rust-lang#141658 and reverts rust-lang#145349.

Reopens rust-lang#138067.

r? ``@fmease``
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 15, 2025
@Zalathar
Rollup merge of rust-lang#145389 - GuillaumeGomez:unstable-search, r=…
21d37d0 
…fmease

[rustdoc] Revert "rustdoc search: prefer stable items in search results"

Reverts rust-lang#141658 and reverts rust-lang#145349.

Reopens rust-lang#138067.

r? ```@fmease```
rust-timer added a commit that referenced this pull request Aug 15, 2025
@rust-timer
Unrolled build for #145389
fe5ad0e 
Rollup merge of #145389 - GuillaumeGomez:unstable-search, r=fmease

[rustdoc] Revert "rustdoc search: prefer stable items in search results"

Reverts #141658 and reverts #145349.

Reopens #138067.

r? ```@fmease```
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 18, 2025
@Zalathar
Rollup merge of #145389 - GuillaumeGomez:unstable-search, r=fmease
e5f6579 
[rustdoc] Revert "rustdoc search: prefer stable items in search results"

Reverts rust-lang/rust#141658 and reverts rust-lang/rust#145349.

Reopens rust-lang/rust#138067.

r? ```@fmease```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolbinarycat lolbinarycat lolbinarycat approved these changes

Assignees

@notriddle notriddle

Labels
A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.

Uncaught DOMException: String contains an invalid character on nightly-rustc docs search
6 participants
@GuillaumeGomez @rustbot @fmease @bors @lolbinarycat @notriddle