-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[DRAFT] Update the minimum external LLVM to 20 #145071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
IMAGE: x86_64-gnu-llvm-19 | ||
DOCKER_SCRIPT: x86_64-gnu-llvm3.sh | ||
<<: *job-linux-4c | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to this PR, but does this mean we're actually running different jobs in PR CI and auto CI? PR CI runs some on aarch64, but here everything uses x86_64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, #141576 only changed the PR side. (cc @marcoieni)
There was also a zulip discussion here.
r=me once it's time. |
With this change, we'll have stable support for LLVM 20 and 21.
For reference, the previous increase to LLVM 19 was #139275.
cc @rust-lang/wg-llvm
r? nikic
NOTE: Fedora 41 is on LLVM 19 and will be EOL in November, which means Rust 1.91 will be its last possible update. Therefore, I'd like to wait until nightly begins Rust 1.92 to merge this.