Skip to content

Move several more float tests to floats/mod.rs #144923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 9, 2025
Merged

Move several more float tests to floats/mod.rs #144923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b4a3d30
Consolidate abs tests
rocurley Jul 14, 2025
83878ea
Consolidate signum tests
rocurley Jul 14, 2025
951ef57
Consolidate is_positive tests
rocurley Jul 14, 2025
71973fc
Consolidate is_sign_negative tests
rocurley Aug 4, 2025
f51f68b
Consolidate test_next_up
rocurley Aug 4, 2025
8a65ce4
Consolidate test_next_down
rocurley Aug 4, 2025
666bfca
Consolidate sqrt_domain tests
rocurley Aug 4, 2025
a5e4e7a
Consolidate clamp tests
rocurley Aug 4, 2025
80bcd1a
Consolidate total_cmp tests
rocurley Aug 4, 2025
57cf40c
Hoist zero and one out into TestableFloat
rocurley Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
290 changes: 0 additions & 290 deletions library/coretests/tests/floats/f128.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,6 @@ const TOL: f128 = 1e-12;
/// signs.
const TOL_PRECISE: f128 = 1e-28;

/// Smallest number
const TINY_BITS: u128 = 0x1;

/// Next smallest number
const TINY_UP_BITS: u128 = 0x2;

/// Exponent = 0b11...10, Sifnificand 0b1111..10. Min val > 0
const MAX_DOWN_BITS: u128 = 0x7ffefffffffffffffffffffffffffffe;

/// Zeroed exponent, full significant
const LARGEST_SUBNORMAL_BITS: u128 = 0x0000ffffffffffffffffffffffffffff;

/// Exponent = 0b1, zeroed significand
const SMALLEST_NORMAL_BITS: u128 = 0x00010000000000000000000000000000;

/// First pattern over the mantissa
const NAN_MASK1: u128 = 0x0000aaaaaaaaaaaaaaaaaaaaaaaaaaaa;

Expand All @@ -39,106 +24,6 @@ const NAN_MASK2: u128 = 0x00005555555555555555555555555555;
// FIXME(f16_f128,miri): many of these have to be disabled since miri does not yet support
// the intrinsics.

#[test]
#[cfg(any(miri, target_has_reliable_f128_math))]
fn test_abs() {
assert_biteq!(f128::INFINITY.abs(), f128::INFINITY);
assert_biteq!(1f128.abs(), 1f128);
assert_biteq!(0f128.abs(), 0f128);
assert_biteq!((-0f128).abs(), 0f128);
assert_biteq!((-1f128).abs(), 1f128);
assert_biteq!(f128::NEG_INFINITY.abs(), f128::INFINITY);
assert_biteq!((1f128 / f128::NEG_INFINITY).abs(), 0f128);
assert!(f128::NAN.abs().is_nan());
}

#[test]
fn test_is_sign_positive() {
assert!(f128::INFINITY.is_sign_positive());
assert!(1f128.is_sign_positive());
assert!(0f128.is_sign_positive());
assert!(!(-0f128).is_sign_positive());
assert!(!(-1f128).is_sign_positive());
assert!(!f128::NEG_INFINITY.is_sign_positive());
assert!(!(1f128 / f128::NEG_INFINITY).is_sign_positive());
assert!(f128::NAN.is_sign_positive());
assert!(!(-f128::NAN).is_sign_positive());
}

#[test]
fn test_is_sign_negative() {
assert!(!f128::INFINITY.is_sign_negative());
assert!(!1f128.is_sign_negative());
assert!(!0f128.is_sign_negative());
assert!((-0f128).is_sign_negative());
assert!((-1f128).is_sign_negative());
assert!(f128::NEG_INFINITY.is_sign_negative());
assert!((1f128 / f128::NEG_INFINITY).is_sign_negative());
assert!(!f128::NAN.is_sign_negative());
assert!((-f128::NAN).is_sign_negative());
}

#[test]
fn test_next_up() {
let tiny = f128::from_bits(TINY_BITS);
let tiny_up = f128::from_bits(TINY_UP_BITS);
let max_down = f128::from_bits(MAX_DOWN_BITS);
let largest_subnormal = f128::from_bits(LARGEST_SUBNORMAL_BITS);
let smallest_normal = f128::from_bits(SMALLEST_NORMAL_BITS);
assert_biteq!(f128::NEG_INFINITY.next_up(), f128::MIN);
assert_biteq!(f128::MIN.next_up(), -max_down);
assert_biteq!((-1.0 - f128::EPSILON).next_up(), -1.0f128);
assert_biteq!((-smallest_normal).next_up(), -largest_subnormal);
assert_biteq!((-tiny_up).next_up(), -tiny);
assert_biteq!((-tiny).next_up(), -0.0f128);
assert_biteq!((-0.0f128).next_up(), tiny);
assert_biteq!(0.0f128.next_up(), tiny);
assert_biteq!(tiny.next_up(), tiny_up);
assert_biteq!(largest_subnormal.next_up(), smallest_normal);
assert_biteq!(1.0f128.next_up(), 1.0 + f128::EPSILON);
assert_biteq!(f128::MAX.next_up(), f128::INFINITY);
assert_biteq!(f128::INFINITY.next_up(), f128::INFINITY);

// Check that NaNs roundtrip.
let nan0 = f128::NAN;
let nan1 = f128::from_bits(f128::NAN.to_bits() ^ 0x002a_aaaa);
let nan2 = f128::from_bits(f128::NAN.to_bits() ^ 0x0055_5555);
assert_biteq!(nan0.next_up(), nan0);
assert_biteq!(nan1.next_up(), nan1);
assert_biteq!(nan2.next_up(), nan2);
}

#[test]
fn test_next_down() {
let tiny = f128::from_bits(TINY_BITS);
let tiny_up = f128::from_bits(TINY_UP_BITS);
let max_down = f128::from_bits(MAX_DOWN_BITS);
let largest_subnormal = f128::from_bits(LARGEST_SUBNORMAL_BITS);
let smallest_normal = f128::from_bits(SMALLEST_NORMAL_BITS);
assert_biteq!(f128::NEG_INFINITY.next_down(), f128::NEG_INFINITY);
assert_biteq!(f128::MIN.next_down(), f128::NEG_INFINITY);
assert_biteq!((-max_down).next_down(), f128::MIN);
assert_biteq!((-1.0f128).next_down(), -1.0 - f128::EPSILON);
assert_biteq!((-largest_subnormal).next_down(), -smallest_normal);
assert_biteq!((-tiny).next_down(), -tiny_up);
assert_biteq!((-0.0f128).next_down(), -tiny);
assert_biteq!((0.0f128).next_down(), -tiny);
assert_biteq!(tiny.next_down(), 0.0f128);
assert_biteq!(tiny_up.next_down(), tiny);
assert_biteq!(smallest_normal.next_down(), largest_subnormal);
assert_biteq!((1.0 + f128::EPSILON).next_down(), 1.0f128);
assert_biteq!(f128::MAX.next_down(), max_down);
assert_biteq!(f128::INFINITY.next_down(), f128::MAX);

// Check that NaNs roundtrip.
let nan0 = f128::NAN;
let nan1 = f128::from_bits(f128::NAN.to_bits() ^ 0x002a_aaaa);
let nan2 = f128::from_bits(f128::NAN.to_bits() ^ 0x0055_5555);
assert_biteq!(nan0.next_down(), nan0);
assert_biteq!(nan1.next_down(), nan1);
assert_biteq!(nan2.next_down(), nan2);
}

#[test]
#[cfg(not(miri))]
#[cfg(target_has_reliable_f128_math)]
Expand Down Expand Up @@ -193,19 +78,6 @@ fn test_powi() {
assert_biteq!(neg_inf.powi(2), inf);
}

#[test]
#[cfg(not(miri))]
#[cfg(target_has_reliable_f128_math)]
fn test_sqrt_domain() {
assert!(f128::NAN.sqrt().is_nan());
assert!(f128::NEG_INFINITY.sqrt().is_nan());
assert!((-1.0f128).sqrt().is_nan());
assert_biteq!((-0.0f128).sqrt(), -0.0);
assert_biteq!(0.0f128.sqrt(), 0.0);
assert_biteq!(1.0f128.sqrt(), 1.0);
assert_biteq!(f128::INFINITY.sqrt(), f128::INFINITY);
}

#[test]
fn test_to_degrees() {
let pi: f128 = consts::PI;
Expand Down Expand Up @@ -260,168 +132,6 @@ fn test_float_bits_conv() {
assert_eq!(f128::from_bits(masked_nan2).to_bits(), masked_nan2);
}

#[test]
#[should_panic]
fn test_clamp_min_greater_than_max() {
let _ = 1.0f128.clamp(3.0, 1.0);
}

#[test]
#[should_panic]
fn test_clamp_min_is_nan() {
let _ = 1.0f128.clamp(f128::NAN, 1.0);
}

#[test]
#[should_panic]
fn test_clamp_max_is_nan() {
let _ = 1.0f128.clamp(3.0, f128::NAN);
}

#[test]
fn test_total_cmp() {
use core::cmp::Ordering;

fn quiet_bit_mask() -> u128 {
1 << (f128::MANTISSA_DIGITS - 2)
}

// FIXME(f16_f128): test subnormals when powf is available
// fn min_subnorm() -> f128 {
// f128::MIN_POSITIVE / f128::powf(2.0, f128::MANTISSA_DIGITS as f128 - 1.0)
// }

// fn max_subnorm() -> f128 {
// f128::MIN_POSITIVE - min_subnorm()
// }

fn q_nan() -> f128 {
f128::from_bits(f128::NAN.to_bits() | quiet_bit_mask())
}

fn s_nan() -> f128 {
f128::from_bits((f128::NAN.to_bits() & !quiet_bit_mask()) + 42)
}

assert_eq!(Ordering::Equal, (-q_nan()).total_cmp(&-q_nan()));
assert_eq!(Ordering::Equal, (-s_nan()).total_cmp(&-s_nan()));
assert_eq!(Ordering::Equal, (-f128::INFINITY).total_cmp(&-f128::INFINITY));
assert_eq!(Ordering::Equal, (-f128::MAX).total_cmp(&-f128::MAX));
assert_eq!(Ordering::Equal, (-2.5_f128).total_cmp(&-2.5));
assert_eq!(Ordering::Equal, (-1.0_f128).total_cmp(&-1.0));
assert_eq!(Ordering::Equal, (-1.5_f128).total_cmp(&-1.5));
assert_eq!(Ordering::Equal, (-0.5_f128).total_cmp(&-0.5));
assert_eq!(Ordering::Equal, (-f128::MIN_POSITIVE).total_cmp(&-f128::MIN_POSITIVE));
// assert_eq!(Ordering::Equal, (-max_subnorm()).total_cmp(&-max_subnorm()));
// assert_eq!(Ordering::Equal, (-min_subnorm()).total_cmp(&-min_subnorm()));
assert_eq!(Ordering::Equal, (-0.0_f128).total_cmp(&-0.0));
assert_eq!(Ordering::Equal, 0.0_f128.total_cmp(&0.0));
// assert_eq!(Ordering::Equal, min_subnorm().total_cmp(&min_subnorm()));
// assert_eq!(Ordering::Equal, max_subnorm().total_cmp(&max_subnorm()));
assert_eq!(Ordering::Equal, f128::MIN_POSITIVE.total_cmp(&f128::MIN_POSITIVE));
assert_eq!(Ordering::Equal, 0.5_f128.total_cmp(&0.5));
assert_eq!(Ordering::Equal, 1.0_f128.total_cmp(&1.0));
assert_eq!(Ordering::Equal, 1.5_f128.total_cmp(&1.5));
assert_eq!(Ordering::Equal, 2.5_f128.total_cmp(&2.5));
assert_eq!(Ordering::Equal, f128::MAX.total_cmp(&f128::MAX));
assert_eq!(Ordering::Equal, f128::INFINITY.total_cmp(&f128::INFINITY));
assert_eq!(Ordering::Equal, s_nan().total_cmp(&s_nan()));
assert_eq!(Ordering::Equal, q_nan().total_cmp(&q_nan()));

assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-s_nan()));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&-f128::INFINITY));
assert_eq!(Ordering::Less, (-f128::INFINITY).total_cmp(&-f128::MAX));
assert_eq!(Ordering::Less, (-f128::MAX).total_cmp(&-2.5));
assert_eq!(Ordering::Less, (-2.5_f128).total_cmp(&-1.5));
assert_eq!(Ordering::Less, (-1.5_f128).total_cmp(&-1.0));
assert_eq!(Ordering::Less, (-1.0_f128).total_cmp(&-0.5));
assert_eq!(Ordering::Less, (-0.5_f128).total_cmp(&-f128::MIN_POSITIVE));
// assert_eq!(Ordering::Less, (-f128::MIN_POSITIVE).total_cmp(&-max_subnorm()));
// assert_eq!(Ordering::Less, (-max_subnorm()).total_cmp(&-min_subnorm()));
// assert_eq!(Ordering::Less, (-min_subnorm()).total_cmp(&-0.0));
assert_eq!(Ordering::Less, (-0.0_f128).total_cmp(&0.0));
// assert_eq!(Ordering::Less, 0.0_f128.total_cmp(&min_subnorm()));
// assert_eq!(Ordering::Less, min_subnorm().total_cmp(&max_subnorm()));
// assert_eq!(Ordering::Less, max_subnorm().total_cmp(&f128::MIN_POSITIVE));
assert_eq!(Ordering::Less, f128::MIN_POSITIVE.total_cmp(&0.5));
assert_eq!(Ordering::Less, 0.5_f128.total_cmp(&1.0));
assert_eq!(Ordering::Less, 1.0_f128.total_cmp(&1.5));
assert_eq!(Ordering::Less, 1.5_f128.total_cmp(&2.5));
assert_eq!(Ordering::Less, 2.5_f128.total_cmp(&f128::MAX));
assert_eq!(Ordering::Less, f128::MAX.total_cmp(&f128::INFINITY));
assert_eq!(Ordering::Less, f128::INFINITY.total_cmp(&s_nan()));
assert_eq!(Ordering::Less, s_nan().total_cmp(&q_nan()));

assert_eq!(Ordering::Greater, (-s_nan()).total_cmp(&-q_nan()));
assert_eq!(Ordering::Greater, (-f128::INFINITY).total_cmp(&-s_nan()));
assert_eq!(Ordering::Greater, (-f128::MAX).total_cmp(&-f128::INFINITY));
assert_eq!(Ordering::Greater, (-2.5_f128).total_cmp(&-f128::MAX));
assert_eq!(Ordering::Greater, (-1.5_f128).total_cmp(&-2.5));
assert_eq!(Ordering::Greater, (-1.0_f128).total_cmp(&-1.5));
assert_eq!(Ordering::Greater, (-0.5_f128).total_cmp(&-1.0));
assert_eq!(Ordering::Greater, (-f128::MIN_POSITIVE).total_cmp(&-0.5));
// assert_eq!(Ordering::Greater, (-max_subnorm()).total_cmp(&-f128::MIN_POSITIVE));
// assert_eq!(Ordering::Greater, (-min_subnorm()).total_cmp(&-max_subnorm()));
// assert_eq!(Ordering::Greater, (-0.0_f128).total_cmp(&-min_subnorm()));
assert_eq!(Ordering::Greater, 0.0_f128.total_cmp(&-0.0));
// assert_eq!(Ordering::Greater, min_subnorm().total_cmp(&0.0));
// assert_eq!(Ordering::Greater, max_subnorm().total_cmp(&min_subnorm()));
// assert_eq!(Ordering::Greater, f128::MIN_POSITIVE.total_cmp(&max_subnorm()));
assert_eq!(Ordering::Greater, 0.5_f128.total_cmp(&f128::MIN_POSITIVE));
assert_eq!(Ordering::Greater, 1.0_f128.total_cmp(&0.5));
assert_eq!(Ordering::Greater, 1.5_f128.total_cmp(&1.0));
assert_eq!(Ordering::Greater, 2.5_f128.total_cmp(&1.5));
assert_eq!(Ordering::Greater, f128::MAX.total_cmp(&2.5));
assert_eq!(Ordering::Greater, f128::INFINITY.total_cmp(&f128::MAX));
assert_eq!(Ordering::Greater, s_nan().total_cmp(&f128::INFINITY));
assert_eq!(Ordering::Greater, q_nan().total_cmp(&s_nan()));

assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-s_nan()));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-f128::INFINITY));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-f128::MAX));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-2.5));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-1.5));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-1.0));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-0.5));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-f128::MIN_POSITIVE));
// assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-max_subnorm()));
// assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-min_subnorm()));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&-0.0));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&0.0));
// assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&min_subnorm()));
// assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&max_subnorm()));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&f128::MIN_POSITIVE));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&0.5));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&1.0));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&1.5));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&2.5));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&f128::MAX));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&f128::INFINITY));
assert_eq!(Ordering::Less, (-q_nan()).total_cmp(&s_nan()));

assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&-f128::INFINITY));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&-f128::MAX));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&-2.5));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&-1.5));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&-1.0));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&-0.5));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&-f128::MIN_POSITIVE));
// assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&-max_subnorm()));
// assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&-min_subnorm()));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&-0.0));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&0.0));
// assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&min_subnorm()));
// assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&max_subnorm()));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&f128::MIN_POSITIVE));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&0.5));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&1.0));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&1.5));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&2.5));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&f128::MAX));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&f128::INFINITY));
assert_eq!(Ordering::Less, (-s_nan()).total_cmp(&s_nan()));
}

#[test]
fn test_algebraic() {
let a: f128 = 123.0;
Expand Down
Loading
Loading