Skip to content

Port #[rustc_pass_by_value] to the new attribute system #143400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

Port #[rustc_pass_by_value] to the new attribute system #143400

merged 2 commits into from
Jul 4, 2025
+32 −13

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Jul 3, 2025 •
edited by rustbot
Loading

Part of #131229

r? @oli-obk

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Jul 4, 2025 •
edited
Loading

@oli-obk will conflict with all the other PRS because of the sorting of the match. Should be @bors rollup=iffy, not rolled up with any other attr related pr, and blocks #143402 and #143403 from approval. Should be approved after mergimg and rebasing on #143237

@jdonszelmann
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 4, 2025

📌 Commit ef4dece has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 4, 2025
Merged
bors added a commit that referenced this pull request Jul 4, 2025
@bors
Auto merge of #143434 - matthiaskrgr:rollup-eyr4rcb, r=matthiaskrgr
0c4fa26 
Rollup of 7 pull requests

Successful merges:

 - #140643 (Refactor StableMIR)
 - #143286 (Make -Ztrack-diagnostics emit like a note)
 - #143308 (Remove `PointerLike` trait)
 - #143387 (Make __rust_alloc_error_handler_should_panic a function)
 - #143400 (Port `#[rustc_pass_by_value]` to the new attribute system)
 - #143417 (bump termize dep)
 - #143420 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f3e7ec5 into rust-lang:master Jul 4, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 4, 2025
rust-timer added a commit that referenced this pull request Jul 4, 2025
@rust-timer
Unrolled build for #143400
034dcc6 
Rollup merge of #143400 - GrigorenkoPV:attributes/lints, r=jdonszelmann

Port `#[rustc_pass_by_value]` to the new attribute system

Part of #131229

r? `@oli-obk`
@GrigorenkoPV GrigorenkoPV deleted the attributes/lints branch July 4, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GrigorenkoPV @rustbot @jdonszelmann @bors @oli-obk