Skip to content

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jul 3, 2025

The first commit slightly reorganizes triagebot.toml (no functional changes) with some dividing sections, because I found it hard to find the actual sections.

The second and third commit configures triagebot to post

PR #{number} has been accepted for {beta,stable} backport.

to compiler/bootstrap backport threads respectively, when beta-accepted Accepted for backporting to the compiler in the beta channel. and stable-accepted Accepted for backporting to the compiler in the stable channel. labels are applied.

Best reviewed commit-by-commit.

cc @Kobzol
r? @apiraino

@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 3, 2025
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@jieyouxu
Copy link
Member Author

jieyouxu commented Jul 3, 2025

Realized that this wasn't configured for both compiler/bootstrap when wondering why #t-infra/bootstrap/backports > #142928: beta-nominated didn't have a beta-accepted notification posted.

Copy link
Contributor

@apiraino apiraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks. I didn't check that the configuration was incomplete.

@jieyouxu
Copy link
Member Author

jieyouxu commented Jul 3, 2025

lgtm, thanks. I didn't check that the configuration was incomplete.

Neither did I when I copy pasted the compiler config for bootstrap 😆

@apiraino
Copy link
Contributor

apiraino commented Jul 3, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 3, 2025

📌 Commit 8ae4fc7 has been approved by apiraino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025
bors added a commit that referenced this pull request Jul 3, 2025
Rollup of 5 pull requests

Successful merges:

 - #141831 (rustdoc: fix attrs of locally reexported foreign items)
 - #143364 (don't include `.md` in title)
 - #143369 (Various refactorings to the metadata loader)
 - #143379 (Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on `{beta,stable}-accepted` label application)
 - #143384 (Update browser-ui-test version to `0.21.1`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3bc36be into rust-lang:master Jul 3, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 3, 2025
rust-timer added a commit that referenced this pull request Jul 3, 2025
Rollup merge of #143379 - jieyouxu:backport-accepted, r=apiraino

Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on `{beta,stable}-accepted` label application

The first commit slightly reorganizes `triagebot.toml` (no functional changes) with some dividing sections, because I found it hard to find the actual sections.

The second and third commit configures triagebot to post

> PR #`{number}` has been **accepted** for **{beta,stable}** backport.

to compiler/bootstrap backport threads respectively, when https://github.com/rust-lang/rust/labels/beta-accepted and https://github.com/rust-lang/rust/labels/stable-accepted labels are applied.

Best reviewed commit-by-commit.

cc `@Kobzol`
r? `@apiraino`
@jieyouxu jieyouxu deleted the backport-accepted branch July 4, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants