Skip to content

Backport rust-lang/stdarch#1818 for 1.88 #142694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Jun 18, 2025

r? cuviper

pietroalbini and others added 27 commits May 9, 2025 18:20
…nglo

[beta-1.88] Update cargo

1 commits in 7918c7eb59614c39f1c4e27e99d557720976bdd7..873a0649350c486caf67be772828a4f36bb4734c
2025-04-27 09:44:23 +0000 to 2025-05-10 06:10:32 -0500
- [beta-1.88] fix(rustc): Don't panic on unknown bins (rust-lang/cargo#15515)

r? ghost
…ietroalbini

Backport rust-lang#140902 to beta

This PR backports rust-lang#140902 to the beta branch, to unblock the stage0 bump.

r? `@ghost`
Unfortunately, multiple people are reporting linker warnings related to
`__rust_no_alloc_shim_is_unstable` after this change. The solution isn't
quite clear yet, let's revert to green for now, and try a reland with a
determined solution for `__rust_no_alloc_shim_is_unstable`.

This reverts commit c8b7f32, reversing
changes made to 667247d.

(cherry picked from commit 734a5b1)
…ad disable problematic test

(cherry picked from commit 6128fca)
…ages

At the moment, it seems like Windows Server 2025 20250504.1.0 is
misconfigured causing insufficient disk space failures. Temporarily go
back to Windows Server 2022 in the hope that those are not also
misconfigured.

(cherry picked from commit f4ce73e)
This is needed to make the cache work after moving CI from the `rust-lang-ci` org to `rust-lang`.

(cherry picked from commit eb53032)
To make it easier to migrate off the `rust-lang-ci/rust` repository.

(cherry picked from commit 7d32303)
This will be used to access secrets once we move off rust-lang-ci.
[beta] backports and stage0 bump

- bump stage0 to 1.87.0
- Update the edition guide for let chains rust-lang#140852
- Fix download of GCC from CI on non-nightly channels rust-lang#140901
- Revert "Fix linking statics on Arm64EC rust-lang#140176" rust-lang#141024
- [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test rust-lang#141045
- Do not call name() on rpitit assoc_item rust-lang#141308
- Temporarily use Windows Server 2022 instead of Windows Server 2025 images rust-lang#141023
- Use Docker cache from the current repository rust-lang#141280
- Move dist-x86_64-linux CI job to GitHub temporarily rust-lang#141388
- ci: prepare aws access keys for migration rust-lang#141389
- Add bors environment to CI rust-lang#141323
-  ci: split dist-arm-linux job rust-lang#141078

r? cuviper
(cherry picked from commit c7a2694)
[beta] backports

- Update to LLVM 20.1.5 rust-lang#141063

r? cuviper
(cherry picked from commit f01bbfc)
If an attribute is re-emitted by a macro, the incorrect edition was used to emit warnings for unsafe attributes

(cherry picked from commit 2c82574)
[beta] backports

- x86 (32/64): go back to passing SIMD vectors by-ptr rust-lang#141309
- use correct edition when warning for unsafe attributes rust-lang#142261

r? cuviper
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • Some commits in this PR modify submodules.
  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

This was referenced Jun 20, 2025
@cuviper
Copy link
Member

cuviper commented Jun 20, 2025

I've included this in #142791.

@rustbot label beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 20, 2025
@Amanieu
Copy link
Member Author

Amanieu commented Jun 20, 2025

It would be useful to have another crater run with this backport, just in case.

@cuviper
Copy link
Member

cuviper commented Jun 20, 2025

Did it show up previously in crater? What do you expect to see (or not)?

@Amanieu
Copy link
Member Author

Amanieu commented Jun 20, 2025

There are actually 2 accidental stabilizations, done at separate times:

  • The vbsl intrinsics for f16 were accidentally stabilized in 1.88 (current beta).
  • The float16x{4,8}_t types were accidentally stabilized in 1.87 (current stable).

It is possible in theory that some people may be already using the float16xN_t types, although that is unlikely since all of the intrinsics that use this type are still unstable.

@cuviper
Copy link
Member

cuviper commented Jun 20, 2025

OK, but crater is still only x86-64 Linux AFAIK, so these aarch64 changes wouldn't show up anyway, right?

bors added a commit that referenced this pull request Jun 20, 2025
[beta] backports

- Make the assertion in `Ident::new` debug-only. #140880
- Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318
- Backport rust-lang/stdarch#1818 for 1.88 #142694
- [beta] Clippy backport #142725
    - ICE:
        - rust-lang/rust-clippy#14776
    - Lint contradictions:
        - rust-lang/rust-clippy#14703
        - rust-lang/rust-clippy#14810
    - Smaller (in LoC changes) fixes:
        - rust-lang/rust-clippy#14733
        - rust-lang/rust-clippy#14730

r? cuviper
rust-bors bot added a commit that referenced this pull request Jun 20, 2025
[beta] backports

- Make the assertion in `Ident::new` debug-only. #140880
- Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318
- Backport rust-lang/stdarch#1818 for 1.88 #142694
- [beta] Clippy backport #142725
    - ICE:
        - rust-lang/rust-clippy#14776
    - Lint contradictions:
        - rust-lang/rust-clippy#14703
        - rust-lang/rust-clippy#14810
    - Smaller (in LoC changes) fixes:
        - rust-lang/rust-clippy#14733
        - rust-lang/rust-clippy#14730

r? cuviper

try-job: x86_64-msvc-ext2
bors added a commit that referenced this pull request Jun 21, 2025
[beta] backports

- Make the assertion in `Ident::new` debug-only. #140880
- Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318
- Backport rust-lang/stdarch#1818 for 1.88 #142694
- [beta] Clippy backport #142725
    - ICE:
        - rust-lang/rust-clippy#14776
    - Lint contradictions:
        - rust-lang/rust-clippy#14703
        - rust-lang/rust-clippy#14810
    - Smaller (in LoC changes) fixes:
        - rust-lang/rust-clippy#14733
        - rust-lang/rust-clippy#14730
-  [win][ci] Update LLVM toolchain used to build LLVM to 20 #140757

r? cuviper
@Amanieu
Copy link
Member Author

Amanieu commented Jun 21, 2025

OK, but crater is still only x86-64 Linux AFAIK, so these aarch64 changes wouldn't show up anyway, right?

Good point, I'd forgotten about that. Perhaps we could do an aarch64 check-only crater run?

@Mark-Simulacrum
Copy link
Member

This was included in #142791, right? Kicked off a check run here - #141588 (comment)

@cuviper cuviper added this to the 1.88.0 milestone Jun 22, 2025
@bors
Copy link
Collaborator

bors commented Jun 23, 2025

☔ The latest upstream changes (presumably #142901) made this pull request unmergeable. Please resolve the merge conflicts.

@cuviper
Copy link
Member

cuviper commented Jun 23, 2025

Conflicts are because the beta branch just moved to 1.89. I'm going to close this, but we'll still need to check the crater results in #141588.

@cuviper cuviper closed this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.