Ensure copy* intrinsics also perform the static self-init checks #142575
Conversation
rustbot
added
S-waiting-on-review
oli-obk
added
the
relnotes
|
Adding relnotes as this will break stable code if someone wrote such code in the last year, but there is absolutely no reason to do so, so not even gonna crater it. |
|
It's a soundness fix and is only reachable by having incorrect unsafe code that should be rejected by const eval anyway, right? Then we're justified in "break first, figure out how to migrate smoothly later". |
|
In theory, this could also affect code where there's correct unsafe code in one crate, and there's incorrect safe code in another crate misusing the first crate. |
| // And our own "do not read from static items while initializing them" checks | ||
| if let Ok((alloc_id, ..)) = self.ptr_try_get_alloc_id(src, size.bytes() as i64) { | ||
| M::before_alloc_read(self, alloc_id)?; | ||
| } |
There was a problem hiding this comment.
Is it possible to move this to right before the before_memory_read below so that we handle both hooks together?
tests/ui/statics/read_before_init.rs
Outdated
There was a problem hiding this comment.
Please add a comment explaining what this is testing and referencing the issue.
oli-obk
force-pushed
the
sneaky-self-init
branch
from
16daf7d to
04f835f
Compare
fixes #142532
r? @RalfJung