Skip to content

Fix borrowck mentioning a name from an external macro we (deliberately) don't save #141891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2025
Merged

Fix borrowck mentioning a name from an external macro we (deliberately) don't save #141891

merged 3 commits into from
Jun 3, 2025

Conversation

jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Jun 2, 2025 •
edited by rustbot
Loading

Most of the info is already in the title 🤷

Closes #141764

@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2025
@rustbot

This comment was marked as outdated.

Sign in to view
jdonszelmann
jdonszelmann commented Jun 2, 2025
View reviewed changes
@jieyouxu jieyouxu mentioned this pull request Jun 2, 2025
Open
jieyouxu
jieyouxu approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me after the FIXME comment

@jieyouxu jieyouxu assigned jieyouxu and unassigned oli-obk Jun 2, 2025
@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
@jdonszelmann
Copy link
Contributor Author

@bors r=jieyouxu rollup

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit 7a1b672 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member

jieyouxu commented Jun 2, 2025 •
edited
Loading

Line number
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2025
@jdonszelmann
Copy link
Contributor Author

ah shoot, so sorry

@compiler-errors
Copy link
Member

@bors r=jieyouxu rollup

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit 8b5b6d0 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
@workingjubilee
Rollup merge of rust-lang#141891 - jdonszelmann:fix-141764, r=jieyouxu
9c2cbe7 
Fix borrowck mentioning a name from an external macro we (deliberately) don't save

Most of the info is already in the title 🤷

Closes rust-lang#141764
@workingjubilee workingjubilee mentioned this pull request Jun 3, 2025
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
@workingjubilee
Rollup merge of rust-lang#141891 - jdonszelmann:fix-141764, r=jieyouxu
8517605 
Fix borrowck mentioning a name from an external macro we (deliberately) don't save

Most of the info is already in the title 🤷

Closes rust-lang#141764
@workingjubilee workingjubilee mentioned this pull request Jun 3, 2025
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 3, 2025
Merged
bors added a commit that referenced this pull request Jun 3, 2025
@bors
Auto merge of #141944 - matthiaskrgr:rollup-e7xhp6w, r=matthiaskrgr
c68032f 
Rollup of 8 pull requests

Successful merges:

 - #140715 (Clarify &mut-methods' docs on sync::OnceLock)
 - #141677 (Async drop - type instead of async drop fn, fixes #140484)
 - #141741 (Overhaul `UsePath`)
 - #141873 (Fixed a typo in `ManuallyDrop`'s doc)
 - #141876 (Don't declare variables in `ExprKind::Let` in invalid positions)
 - #141886 (Add missing 2015 edition directives)
 - #141889 (Add missing `dyn` keywords to tests that do not test for them)
 - #141891 (Fix borrowck mentioning a name from an external macro we (deliberately) don't save)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f3622ea into rust-lang:master Jun 3, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jun 3, 2025
@rust-timer
Unrolled build for #141891
292f076 
Rollup merge of #141891 - jdonszelmann:fix-141764, r=jieyouxu

Fix borrowck mentioning a name from an external macro we (deliberately) don't save

Most of the info is already in the title 🤷

Closes #141764
@rustbot rustbot added this to the 1.89.0 milestone Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

ICE: called Option::unwrap() on a None value in when using proc macro
7 participants
@jdonszelmann @rustbot @bors @rust-log-analyzer @jieyouxu @compiler-errors @oli-obk