Stabilize `ip_from` #141744

GrigorenkoPV · 2025-05-29T19:20:00Z

Tracking issue: #131360

Stabilizes and const-stabilizes the following APIs:

// core::net
impl Ipv4Addr {
    pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr;
}
impl Ipv6Addr {
    pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr;
    pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr;
}

Closes #131360

@rustbot label +needs-fcp

rustbot · 2025-05-29T19:20:04Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-05-30T00:47:00Z

r? libs-api

GrigorenkoPV · 2025-06-16T15:41:38Z

r? libs-api

Amanieu · 2025-06-19T19:01:00Z

@rfcbot merge

rfcbot · 2025-06-19T19:01:01Z

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2025-08-05T13:04:09Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2025-08-15T13:04:17Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

Amanieu · 2025-08-16T22:46:04Z

@bors r+

bors · 2025-08-16T22:46:07Z

📌 Commit 964eb82 has been approved by Amanieu

It is now in the queue for this repository.

Stabilize `ip_from` Tracking issue: rust-lang#131360 Stabilizes and const-stabilizes the following APIs: ```rust // core::net impl Ipv4Addr { pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr; } impl Ipv6Addr { pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr; pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr; } ``` Closes rust-lang#131360 `@rustbot` label +needs-fcp

Stabilize `ip_from` Tracking issue: rust-lang#131360 Stabilizes and const-stabilizes the following APIs: ```rust // core::net impl Ipv4Addr { pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr; } impl Ipv6Addr { pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr; pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr; } ``` Closes rust-lang#131360 ``@rustbot`` label +needs-fcp

Stabilize `ip_from` Tracking issue: rust-lang#131360 Stabilizes and const-stabilizes the following APIs: ```rust // core::net impl Ipv4Addr { pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr; } impl Ipv6Addr { pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr; pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr; } ``` Closes rust-lang#131360 ```@rustbot``` label +needs-fcp

Stabilize `ip_from` Tracking issue: rust-lang#131360 Stabilizes and const-stabilizes the following APIs: ```rust // core::net impl Ipv4Addr { pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr; } impl Ipv6Addr { pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr; pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr; } ``` Closes rust-lang#131360 ````@rustbot```` label +needs-fcp

Stabilize `ip_from` Tracking issue: rust-lang#131360 Stabilizes and const-stabilizes the following APIs: ```rust // core::net impl Ipv4Addr { pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr; } impl Ipv6Addr { pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr; pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr; } ``` Closes rust-lang#131360 `````@rustbot````` label +needs-fcp

Rollup of 19 pull requests Successful merges: - #140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`) - #141744 (Stabilize `ip_from`) - #144804 (Don't warn on never to any `as` casts as unreachable) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145041 (rework GAT borrowck limitation error) - #145243 (take attr style into account in diagnostics) - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145486 (Fix `unicode_data.rs` mention message) - #145489 (library: Migrate from `cfg_if` to `cfg_select`) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145500 (Port must_use to the new target checking) - #145505 (Simplify span caches) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145516 (Weekly `cargo update`) - #145533 (Reorder `lto` options from most to least optimizing) - #145550 (Avoid using `()` in `derive(From)` output.) r? `@ghost` `@rustbot` modify labels: rollup

Stabilize `ip_from` Tracking issue: rust-lang#131360 Stabilizes and const-stabilizes the following APIs: ```rust // core::net impl Ipv4Addr { pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr; } impl Ipv6Addr { pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr; pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr; } ``` Closes rust-lang#131360 ``````@rustbot`````` label +needs-fcp

Stabilize `ip_from` Tracking issue: rust-lang#131360 Stabilizes and const-stabilizes the following APIs: ```rust // core::net impl Ipv4Addr { pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr; } impl Ipv6Addr { pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr; pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr; } ``` Closes rust-lang#131360 `@rustbot` label +needs-fcp

Stabilize `ip_from` Tracking issue: rust-lang#131360 Stabilizes and const-stabilizes the following APIs: ```rust // core::net impl Ipv4Addr { pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr; } impl Ipv6Addr { pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr; pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr; } ``` Closes rust-lang#131360 ``@rustbot`` label +needs-fcp

Rollup of 19 pull requests Successful merges: - #140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`) - #141744 (Stabilize `ip_from`) - #142681 (Remove the `#[no_sanitize]` attribute in favor of `#[sanitize(xyz = "on|off")]`) - #142871 (Trivial improve doc for transpose ) - #144252 (Do not copy .rmeta files into the sysroot of the build compiler during check of rustc/std) - #144476 (rustdoc-search: search backend with partitioned suffix tree) - #144567 (Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases) - #144804 (Don't warn on never to any `as` casts as unreachable) - #144960 ([RTE-513] Ignore sleep_until test on SGX) - #145013 (overhaul `&mut` suggestions in borrowck errors) - #145041 (rework GAT borrowck limitation error) - #145243 (take attr style into account in diagnostics) - #145405 (cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths) - #145432 (cg_llvm: Small cleanups to `owned_target_machine`) - #145484 (Remove `LlvmArchiveBuilder` and supporting code/bindings) - #145557 (Fix uplifting in `Assemble` step) - #145563 (Remove the `From` derive macro from prelude) - #145565 (Improve context of bootstrap errors in CI) - #145584 (interpret: avoid forcing all integer newtypes into memory during clear_provenance) Failed merges: - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one) - #145573 (Add an experimental unsafe(force_target_feature) attribute.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #141744 - GrigorenkoPV:ip_from, r=Amanieu Stabilize `ip_from` Tracking issue: #131360 Stabilizes and const-stabilizes the following APIs: ```rust // core::net impl Ipv4Addr { pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr; } impl Ipv6Addr { pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr; pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr; } ``` Closes #131360 ```@rustbot``` label +needs-fcp

Zalathar · 2025-08-19T10:09:31Z

Bors hasn't noticed that this was merged.

@bors r- retry

Stabilize `ip_from` Tracking issue: rust-lang#131360 Stabilizes and const-stabilizes the following APIs: ```rust // core::net impl Ipv4Addr { pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr; } impl Ipv6Addr { pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr; pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr; } ``` Closes rust-lang#131360 ```@rustbot``` label +needs-fcp

Rollup of 19 pull requests Successful merges: - rust-lang/rust#140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`) - rust-lang/rust#141744 (Stabilize `ip_from`) - rust-lang/rust#142681 (Remove the `#[no_sanitize]` attribute in favor of `#[sanitize(xyz = "on|off")]`) - rust-lang/rust#142871 (Trivial improve doc for transpose ) - rust-lang/rust#144252 (Do not copy .rmeta files into the sysroot of the build compiler during check of rustc/std) - rust-lang/rust#144476 (rustdoc-search: search backend with partitioned suffix tree) - rust-lang/rust#144567 (Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases) - rust-lang/rust#144804 (Don't warn on never to any `as` casts as unreachable) - rust-lang/rust#144960 ([RTE-513] Ignore sleep_until test on SGX) - rust-lang/rust#145013 (overhaul `&mut` suggestions in borrowck errors) - rust-lang/rust#145041 (rework GAT borrowck limitation error) - rust-lang/rust#145243 (take attr style into account in diagnostics) - rust-lang/rust#145405 (cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths) - rust-lang/rust#145432 (cg_llvm: Small cleanups to `owned_target_machine`) - rust-lang/rust#145484 (Remove `LlvmArchiveBuilder` and supporting code/bindings) - rust-lang/rust#145557 (Fix uplifting in `Assemble` step) - rust-lang/rust#145563 (Remove the `From` derive macro from prelude) - rust-lang/rust#145565 (Improve context of bootstrap errors in CI) - rust-lang/rust#145584 (interpret: avoid forcing all integer newtypes into memory during clear_provenance) Failed merges: - rust-lang/rust#145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one) - rust-lang/rust#145573 (Add an experimental unsafe(force_target_feature) attribute.) r? `@ghost` `@rustbot` modify labels: rollup

Stabilize ip_from

964eb82

rustbot assigned Mark-Simulacrum May 29, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels May 29, 2025

rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 30, 2025

rustbot assigned m-ou-se and unassigned Mark-Simulacrum May 30, 2025

jieyouxu removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 30, 2025

rustbot assigned Amanieu and unassigned m-ou-se Jun 16, 2025

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 19, 2025

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 5, 2025

rustbot mentioned this pull request Aug 15, 2025

Tracking issue for release notes of #141744: Stabilize ip_from #145440

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2025

jhpratt mentioned this pull request Aug 17, 2025

Manual rollup of 19 pull requests #145545

Closed

jhpratt mentioned this pull request Aug 17, 2025

Rollup of 19 pull requests #145546

Closed

Zalathar mentioned this pull request Aug 18, 2025

Rollup of 19 pull requests #145552

Closed

Zalathar mentioned this pull request Aug 18, 2025

Rollup of 18 pull requests #145566

Closed

Zalathar mentioned this pull request Aug 19, 2025

Rollup of 19 pull requests #145589

Merged

bors merged commit 027c7a5 into rust-lang:master Aug 19, 2025
9 checks passed

rustbot added this to the 1.91.0 milestone Aug 19, 2025

Dirbaio mentioned this pull request Aug 19, 2025

Tracking Issue for Ipv[46]Address::from_octets, Ipv6Address::from_segments #131360

Closed

4 tasks

GrigorenkoPV deleted the ip_from branch August 19, 2025 20:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stabilize `ip_from` #141744

Stabilize `ip_from` #141744

GrigorenkoPV commented May 29, 2025 •

edited by rustbot

Loading

Uh oh!

rustbot commented May 29, 2025

Uh oh!

jieyouxu commented May 30, 2025

Uh oh!

GrigorenkoPV commented Jun 16, 2025

Uh oh!

Amanieu commented Jun 19, 2025

Uh oh!

rfcbot commented Jun 19, 2025 •

edited by joshtriplett

Loading

Uh oh!

rfcbot commented Aug 5, 2025

Uh oh!

rfcbot commented Aug 15, 2025

Uh oh!

Amanieu commented Aug 16, 2025

Uh oh!

bors commented Aug 16, 2025

Uh oh!

Uh oh!

Zalathar commented Aug 19, 2025

Uh oh!

Uh oh!

Stabilize ip_from #141744

Stabilize ip_from #141744

Conversation

GrigorenkoPV commented May 29, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 29, 2025

Uh oh!

jieyouxu commented May 30, 2025

Uh oh!

GrigorenkoPV commented Jun 16, 2025

Uh oh!

Amanieu commented Jun 19, 2025

Uh oh!

rfcbot commented Jun 19, 2025 • edited by joshtriplett Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Aug 5, 2025

Uh oh!

rfcbot commented Aug 15, 2025

Uh oh!

Amanieu commented Aug 16, 2025

Uh oh!

bors commented Aug 16, 2025

Uh oh!

Uh oh!

Zalathar commented Aug 19, 2025

Uh oh!

Uh oh!

Stabilize `ip_from` #141744

Stabilize `ip_from` #141744

GrigorenkoPV commented May 29, 2025 •

edited by rustbot

Loading

rfcbot commented Jun 19, 2025 •

edited by joshtriplett

Loading