Skip to content

Revert "Deduplicate template parameter creation" #139878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Revert "Deduplicate template parameter creation" #139878

merged 1 commit into from
Apr 16, 2025
+45 −26

Conversation

petrochenkov
Copy link
Contributor

This reverts commit 6adc2c1.

More precise subset of #139874.

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2025
@petrochenkov
Copy link
Contributor Author

@bors r=compiler-errors #139874 (comment)

@bors
Copy link
Collaborator

bors commented Apr 15, 2025

📌 Commit 38f7060 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2025
@petrochenkov petrochenkov mentioned this pull request Apr 15, 2025
Closed
@petrochenkov
Copy link
Contributor Author

@bors rollup=never

@compiler-errors
Copy link
Member

👍

@bors
Copy link
Collaborator

bors commented Apr 15, 2025

⌛ Testing commit 38f7060 with merge cacb9ee...

@bors
Copy link
Collaborator

bors commented Apr 16, 2025

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing cacb9ee to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 16, 2025
@bors bors merged commit cacb9ee into rust-lang:master Apr 16, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 38c560a (parent) -> cacb9ee (this PR)

Test differences

No test diffs found

Job duration changes

  1. x86_64-apple-2: 4916.9s -> 6496.4s (32.1%)
  2. dist-apple-various: 9698.1s -> 7598.2s (-21.7%)
  3. x86_64-apple-1: 7372.0s -> 8666.2s (17.6%)
  4. i686-msvc-2: 8365.0s -> 7330.6s (-12.4%)
  5. i686-gnu-nopt-2: 7147.5s -> 6389.4s (-10.6%)
  6. x86_64-gnu-llvm-19-2: 6189.7s -> 5575.7s (-9.9%)
  7. dist-x86_64-mingw: 7476.1s -> 8073.2s (8.0%)
  8. armhf-gnu: 4772.0s -> 4405.1s (-7.7%)
  9. dist-i586-gnu-i586-i686-musl: 5472.6s -> 5099.3s (-6.8%)
  10. dist-loongarch64-linux: 6308.7s -> 6605.6s (4.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cacb9ee): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -5.8% [-12.9%, -0.6%] 11
Improvements ✅
(secondary)		 -2.9% [-8.7%, -0.3%] 34
All ❌✅ (primary) -5.8% [-12.9%, -0.6%] 11

Max RSS (memory usage)

Results (primary -0.3%, secondary 7.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.9% [0.4%, 3.0%] 7
Regressions ❌
(secondary)		 7.5% [7.5%, 7.5%] 1
Improvements ✅
(primary)		 -2.9% [-4.6%, -0.8%] 3
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.3% [-4.6%, 3.0%] 10

Cycles

Results (primary -2.9%, secondary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.4% [0.4%, 0.4%] 2
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 -4.0% [-10.7%, -0.4%] 6
Improvements ✅
(secondary)		 -1.9% [-2.3%, -1.6%] 2
All ❌✅ (primary) -2.9% [-10.7%, 0.4%] 8

Binary size

Results (primary -7.4%, secondary -10.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -7.4% [-15.2%, -0.9%] 16
Improvements ✅
(secondary)		 -10.0% [-10.3%, -7.9%] 37
All ❌✅ (primary) -7.4% [-15.2%, -0.9%] 16

Bootstrap: 781.698s -> 782.111s (0.05%)
Artifact size: 365.13 MiB -> 364.73 MiB (-0.11%)

@petrochenkov petrochenkov added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 16, 2025
@apiraino
Copy link
Contributor

Beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 17, 2025
@cuviper cuviper mentioned this pull request Apr 17, 2025
Merged
@cuviper cuviper modified the milestones: 1.88.0, 1.87.0 Apr 17, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 17, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2025
@bors
Auto merge of rust-lang#139988 - cuviper:beta-next, r=cuviper
386abeb 
[beta] backports

- Fix 2024 edition doctest panic output rust-lang#139328
- make `Arguments::as_statically_known_str` doc(hidden) rust-lang#139389
- Revert "Deduplicate template parameter creation" rust-lang#139878
- sync::mpsc: prevent double free on `Drop` rust-lang#139553

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
8 participants
@petrochenkov @rustbot @bors @compiler-errors @rust-timer @apiraino @cuviper @oli-obk