Mention Both HRTB and Generic Lifetime Param in E0637 documentation
#123247
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
That's true but that particular suggestion is not super smart and has many issues (that are currently being worked on though) like #123713, #122714 or #122025. Therefore, it shouldn't be taken as a source of absolute truth. For example, fn and_without_explicit_lifetime<T>()
where
T: Iterator<Item = &u32>,
{
}which is not correct (#122025). |
|
As a middle ground instead of replacing the @rustbot author |
rustbot
added
S-waiting-on-author
|
Sure, mentioning both sounds good to me. I've also fixed the grammar in the first line: |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
fmease
reviewed
Apr 27, 2024
Also, small grammar fix.
veera-sivarajan
force-pushed
the
fix-error-code-E0637-example-code
branch
from
9e5d607 to
26ed429
Compare
veera-sivarajan
changed the title
E0637 documentationE0637 documentation
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 30, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#123247 (Mention Both HRTB and Generic Lifetime Param in `E0637` documentation) - rust-lang#124511 (Remove many `#[macro_use] extern crate foo` items) - rust-lang#124550 (Remove redundant union check in `KnownPanicsLint` const prop) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 30, 2024
Rollup merge of rust-lang#123247 - veera-sivarajan:fix-error-code-E0637-example-code, r=fmease Mention Both HRTB and Generic Lifetime Param in `E0637` documentation The compiler (rustc 1.77.0) error for `and_without_explicit_lifetime()` in the erroneous code example suggests using a HRTB. But, the corrected example uses an explicit lifetime parameter. This PR fixes it so that the documentation and the compiler suggestion for error code `E0637` are consistent with each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler (rustc 1.77.0) error for
and_without_explicit_lifetime()in the erroneous code example suggests using a HRTB. But, the corrected example uses an explicit lifetime parameter.This PR fixes it so that the documentation and the compiler suggestion for error code
E0637are consistent with each other.