Removed unnecessary &String -> &str, now that &String implements StableOrd as well #112538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
(can you give this PR a better title than just referencing another PR? 😸) |
ndrewxie
changed the title
ndrewxie
changed the title
ndrewxie
changed the title
compiler-errors
changed the title
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 21, 2023
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#112538 (Removed unnecessary &String -> &str, now that &String implements StableOrd as well) - rust-lang#112868 (Liberate bound vars properly when suggesting missing async-fn-in-trait) - rust-lang#112892 (resolve: Minor cleanup to `fn resolve_path_with_ribs`) - rust-lang#112894 (Fix union fields display) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied a few nits suggested by lcnr to PR #110040 (nits can be found here.)
Making a new PR because the old one was already merged, and given that this just applies changes that were already suggested, reviewing it should be fairly open-and-shut.