Skip to content

miri compiletest: no longer allow some warnings in rustc test suite #112241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

miri compiletest: no longer allow some warnings in rustc test suite #112241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions src/tools/miri/tests/compiletest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,9 @@ fn test_config(target: &str, path: &str, mode: Mode, with_dependencies: bool) ->
let mut program = CommandBuilder::rustc();
program.program = miri_path();

let in_rustc_test_suite = option_env!("RUSTC_STAGE").is_some();

// Add some flags we always want.
if in_rustc_test_suite {
// Less aggressive warnings to make the rustc toolstate management less painful.
// (We often get warnings when e.g. a feature gets stabilized or some lint gets added/improved.)
program.args.push("-Astable-features".into());
program.args.push("-Aunused".into());
} else {
program.args.push("-Dwarnings".into());
program.args.push("-Dunused".into());
}
program.args.push("-Dwarnings".into());
program.args.push("-Dunused".into());
if let Ok(extra_flags) = env::var("MIRIFLAGS") {
for flag in extra_flags.split_whitespace() {
program.args.push(flag.into());
Expand Down