Skip to content

Conversation

WaffleLapkin
Copy link
Member

.is_some_and(..)/.is_ok_and(..) replace .map_or(false, ..) and .map(..).unwrap_or(false), making the code more readable.

This PR is a sibling of #111873 (comment)

@rustbot
Copy link
Collaborator

rustbot commented May 24, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 24, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 24, 2023

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in need_type_info.rs

cc @lcnr

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@WaffleLapkin WaffleLapkin removed A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 24, 2023
@petrochenkov
Copy link
Contributor

Another use case for EXPR is PAT pattern matching expressions (rust-lang/rfcs#2497 (comment)).
x.is_some_and(|y| y > 0) -> x is Some(y) && y > 0.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented May 24, 2023

📌 Commit 307799a has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2023
…earth

Rollup of 5 pull requests

Successful merges:

 - rust-lang#111741 (Use `ObligationCtxt` in custom type ops)
 - rust-lang#111840 (Expose more information in `get_body_with_borrowck_facts`)
 - rust-lang#111876 (Roll compiler_builtins to 0.1.92)
 - rust-lang#111912 (Use `Option::is_some_and` and `Result::is_ok_and` in the compiler  )
 - rust-lang#111915 (libtest: Improve error when missing `-Zunstable-options`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d0b3ebe into rust-lang:master May 25, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 25, 2023
@WaffleLapkin WaffleLapkin deleted the is_some_and_in_the_compiler branch June 1, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants