Skip to content

Better diagnostics for env! where variable contains escape #111463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2023
Merged

Better diagnostics for env! where variable contains escape #111463

merged 1 commit into from
May 14, 2023

Conversation

clubby789
Copy link
Contributor

Fixes #110559

@clubby789 clubby789 added the A-diagnostics Area: Messages for errors, warnings, and lints label May 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 11, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 11, 2023
cjgillot
cjgillot reviewed May 11, 2023
View reviewed changes
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented May 13, 2023

📌 Commit 2555f3b has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2023
@bors
Auto merge of rust-lang#111552 - matthiaskrgr:rollup-4nidoti, r=matth…
0a0e045 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#111463 (Better diagnostics for `env!` where variable contains escape)
 - rust-lang#111477 (better diagnostics for `impl<..> impl Trait for Type`)
 - rust-lang#111534 (rustdoc-json: Add tests for `#![feature(inherent_associated_types)]`)
 - rust-lang#111549 ([rustdoc] Convert more GUI tests colors to their original format)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0b8f2bf into rust-lang:master May 14, 2023
@bors
Copy link
Collaborator

bors commented May 14, 2023

⌛ Testing commit 2555f3b with merge 0a0e045...

@rustbot rustbot added this to the 1.71.0 milestone May 14, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

diagnostics look weird when rustc is trying to quote whitespace characters
4 participants
@clubby789 @rustbot @cjgillot @bors