Codegen test for derived < on trivial newtype [TEST ONLY]
#106100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, rustbot didn't give me a reviewer, so I'll copy over the one from my other PR |
|
oh lol, triagebot.toml is broken. let me put up a fix. |
|
@bors r+ rollup |
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 24, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#105465 (Improve top-level docs) - rust-lang#105872 (Suggest remove last method call when type coerce with expected type) - rust-lang#106032 (std: only use LFS function on glibc) - rust-lang#106078 (Provide more context on FileCheck failures) - rust-lang#106100 (Codegen test for derived `<` on trivial newtype [TEST ONLY]) - rust-lang#106109 (rustdoc: make line number CSS for doc comment and scraped the same) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally wrote this for #106065, but the libcore changes there aren't necessarily a win.
So I pulled out this test to be its own PR since it's important (see #105840 (comment)) and well-intentioned changes to core or the derive could accidentally break it without that being obvious (other than by massive unexplained perf changes).