Skip to content

Limit efiapi calling convention to supported arches #104020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2022
Merged

Limit efiapi calling convention to supported arches #104020

merged 1 commit into from
Nov 10, 2022

Conversation

nicholasbishop
Copy link
Contributor

Supported architectures in UEFI are described here:
https://uefi.org/specs/UEFI/2.10/02_Overview.html#calling-conventions

#65815

@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2022

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 5, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2022

These commits modify compiler targets.
(See the Target Tier Policy.)

@nagisa
Copy link
Member

nagisa commented Nov 6, 2022

r? @nagisa
@bors r+

@bors
Copy link
Collaborator

bors commented Nov 6, 2022

📌 Commit 28a1852 has been approved by nagisa

It is now in the queue for this repository.

@rustbot rustbot assigned nagisa and unassigned wesleywiser Nov 6, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 6, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2022
@matthiaskrgr
Rollup merge of rust-lang#104020 - nicholasbishop:bishop-limit-efiapi…
b301b37 
…, r=nagisa

Limit efiapi calling convention to supported arches

Supported architectures in UEFI are described here:
https://uefi.org/specs/UEFI/2.10/02_Overview.html#calling-conventions

rust-lang#65815
@matthiaskrgr
Copy link
Member

@bors r- failed in a rollup
#104041 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 6, 2022
@nicholasbishop
Copy link
Contributor Author

Updated feature-gate tests using 8240e7a as a model.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2022
@nagisa
Copy link
Member

nagisa commented Nov 6, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 6, 2022

📌 Commit bd399d36af973509f7307c8149807d1618629d37 has been approved by nagisa

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2022
@bors
Copy link
Collaborator

bors commented Nov 6, 2022

☔ The latest upstream changes (presumably #99943) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 6, 2022
@nicholasbishop
Copy link
Contributor Author

Rebased to fix the conflict.

@nicholasbishop
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2022
@nagisa
Copy link
Member

nagisa commented Nov 6, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 6, 2022

📌 Commit 16edaa5 has been approved by nagisa

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2022
@Manishearth Manishearth mentioned this pull request Nov 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 9, 2022
@bors
Auto merge of rust-lang#104215 - Manishearth:rollup-5r957ad, r=Manish…
34115d0 
…earth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#101005 (Migrate rustc_codegen_llvm to SessionDiagnostics)
 - rust-lang#103307 (Add context to compiler error message)
 - rust-lang#103464 (Add support for custom mir)
 - rust-lang#103929 (Cleanup Apple-related code in rustc_target)
 - rust-lang#104015 (Remove linuxkernel targets)
 - rust-lang#104020 (Limit efiapi calling convention to supported arches)
 - rust-lang#104156 (Cleanups in autoderef impl)
 - rust-lang#104171 (Update books)
 - rust-lang#104184 (Fix `rustdoc --version` when used with download-rustc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bfd637a into rust-lang:master Nov 10, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 10, 2022
@nicholasbishop nicholasbishop deleted the bishop-limit-efiapi branch November 13, 2022 18:39
@nicholasbishop nicholasbishop mentioned this pull request Nov 28, 2022
Closed
@workingjubilee workingjubilee added O-UEFI UEFI O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-x86 O-x86_64 Target: x86-64 processors (like x86_64-*) (also known as amd64 and x64) O-riscv Target: RISC-V architecture O-AArch64 Armv8-A or later processors in AArch64 mode labels Feb 27, 2023
@Noratrieb Noratrieb added O-x86_32 Target: x86 processors, 32 bit (like i686-*) (also known as IA-32, i386, i586, i686) and removed O-x86-all labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
O-AArch64 Armv8-A or later processors in AArch64 mode O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-riscv Target: RISC-V architecture O-UEFI UEFI O-x86_32 Target: x86 processors, 32 bit (like i686-*) (also known as IA-32, i386, i586, i686) O-x86_64 Target: x86-64 processors (like x86_64-*) (also known as amd64 and x64) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
8 participants
@nicholasbishop @rustbot @nagisa @bors @matthiaskrgr @wesleywiser @workingjubilee @Noratrieb