New error format: all diagnostics are now highlighted as errors

[birkenfeld]

With the old error format, rust-mode was able to recognize errors, warnings and other info messages. The result was that compilation-mode could use different faces to distinguish between messages visually (compilation-error, compilation-warning, compilation-info).

This is now gone; all diagnostics are categorized as errors and highlighted as such (or rather, their position is). Since notes/help do no longer have individual file:line, it's not particularly serious, but unfortunate.

[nikomatsakis]

Ah yes, I meant to address this by changing the new error format generating code.

[qdot]

+1 on this since the new error format landed in nightly but compilation mode highlighting hasn't been updated yet.

[blaenk]

Just wanted to state another reason for fixing this. Emacs commit emacs-mirror/emacs@846870e added automatic support for counting each type of error, so that for example, the count of each can be displayed on the mode-line.

I added this information to my mode-line but indeed all errors regardless of type show up as errors (despite them all being warnings in my case, for example).