Skip to content

split clippy into lints, plugin and cargo-clippy #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2016
Merged

split clippy into lints, plugin and cargo-clippy #950

merged 1 commit into from
May 27, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 24, 2016

an alternative to #933

@@ -0,0 +1,25 @@
[package]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be an rlib? This would make compilation fast again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why that would speed it up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wait, no, the default cargo behavior would work here anyway. Nvm

@Manishearth
Copy link
Member

This is awesome! I was dreading having to make this change 😛

Thanks so much! Overall lgtm, I'll have a closer look tomorrow.

@oli-obk
Copy link
Contributor Author

oli-obk commented May 24, 2016

I was dreading having to make this change

Well... You're gonna have to publish two crates from now on instead of one, + keep the versions synced I think, I don't know if cargo allows 0.0.* as a version, so this might not be publishable

@Manishearth
Copy link
Member

Three crates, actually?

@Manishearth
Copy link
Member

Oh, only two.

@oli-obk
Copy link
Contributor Author

oli-obk commented May 27, 2016

rebased

@Manishearth
Copy link
Member

This looks good to me.

@mcarton @birkenfeld @llogiq Note that there are two package versions to bump now.

@Manishearth Manishearth merged commit 9110b6e into rust-lang:master May 27, 2016
@@ -30,6 +29,7 @@ semver = "0.2.1"
toml = "0.1"
unicode-normalization = "0.1"
quine-mc_cluskey = "0.2.2"
clippy_lints = { version = "0.0.*", path = "clippy_lints" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it occurred to me that we might want to hardcode the version so as to avoid upgrade pains -- people shouldn't have to cargo update -p clippy and then still get errors because they didn't upgrade clippy_lints. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add this to utils/update_lints.py so the version is automatically checked

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet. separate PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe someone who knows python should do that... or I can port it to Rust

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcarton ?

Otherwise I'll fix it monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants