Skip to content

Require the changelog: entry in the PR body to be modified #6288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Nov 4, 2020

r? @matthiaskrgr

changelog: none

@flip1995
Copy link
Member Author

flip1995 commented Nov 4, 2020

@bors try

bors added a commit that referenced this pull request Nov 4, 2020
[WIP] Require the `changelog:` entry in the PR body to be modified

r? `@ghost` (CI PR, so expect many bors tries. Will assign later)

changelog: none
@bors
Copy link
Contributor

bors commented Nov 4, 2020

⌛ Trying commit e6276ec with merge ef358d1...

@flip1995
Copy link
Member Author

flip1995 commented Nov 4, 2020

@bors try

bors added a commit that referenced this pull request Nov 4, 2020
[WIP] Require the `changelog:` entry in the PR body to be modified

r? `@ghost` (CI PR, so expect many bors tries. Will assign later)

changelog: none
@bors
Copy link
Contributor

bors commented Nov 4, 2020

⌛ Trying commit a65600d with merge ea93488...

@bors
Copy link
Contributor

bors commented Nov 4, 2020

💔 Test failed - checks-action_test

@matthiaskrgr
Copy link
Member

Could we leave it at changelog: (this might encourage uses to fill it out) but keep accepting changelog: none perhaps?

@flip1995 flip1995 force-pushed the changelog_internal branch 3 times, most recently from 47bd0b1 to 07b97ac Compare November 8, 2020 15:15
@flip1995 flip1995 changed the title [WIP] Require the changelog: entry in the PR body to be modified Require the changelog: entry in the PR body to be modified Nov 8, 2020
@matthiaskrgr
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2020

📌 Commit 7c612c1 has been approved by matthiaskrgr

@bors
Copy link
Contributor

bors commented Nov 8, 2020

⌛ Testing commit 7c612c1 with merge 040d0ca...

@bors
Copy link
Contributor

bors commented Nov 8, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing 040d0ca to master...

@bors bors merged commit 040d0ca into rust-lang:master Nov 8, 2020
@flip1995 flip1995 deleted the changelog_internal branch November 8, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants