Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Aug 14, 2025

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 14, 2025
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. Can you squash?

replace multiple `if-let`s with `match`

turn the condition into a match guard

allows removing the `else` branch

replace `Vec::append` with `extend`

don't need the second vec after this operation anyway

remove `return`s
@ada4a ada4a force-pushed the unnecessary_unwrap-cleanup branch from e4ef083 to a8b52ba Compare August 16, 2025 01:04
@ada4a
Copy link
Contributor Author

ada4a commented Aug 16, 2025

squashed (and rebased)!

@y21 y21 added this pull request to the merge queue Aug 16, 2025
Merged via the queue into rust-lang:master with commit aa8b09d Aug 16, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 16, 2025
@ada4a ada4a deleted the unnecessary_unwrap-cleanup branch August 16, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants