Skip to content

Do not replace match by if if any arm contains a binding #15352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

Do not replace match by if if any arm contains a binding #15352

merged 1 commit into from
Aug 21, 2025

Conversation

samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Jul 26, 2025 •
edited by rustbot
Loading

changelog: [match_bool]: do not replace match by if if any arm contains a binding

Fixes #15351

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 26, 2025
Alexendoo
Alexendoo approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Alexendoo Alexendoo added this pull request to the merge queue Aug 21, 2025
Merged via the queue into rust-lang:master with commit 743405d Aug 21, 2025
11 of 13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 21, 2025
@samueltardieu samueltardieu deleted the issue15351 branch August 21, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexendoo Alexendoo Alexendoo approved these changes

+1 more reviewer

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Alexendoo Alexendoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

match_bool will suggetion will introduce untinitialized binding that still existed in the match arm
4 participants
@samueltardieu @rustbot @Alexendoo @GuillaumeGomez