Skip to content

Fix if_then_some_else_none FP when require type coercion #15267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blyxyas merged 1 commit into from
Jul 24, 2025
Merged

Fix if_then_some_else_none FP when require type coercion #15267

blyxyas merged 1 commit into from
Jul 24, 2025
+251 −3

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Jul 13, 2025 •
edited by rustbot
Loading

Closes #15257

changelog: [if_then_some_else_none] fix FP when require type coercion

@rustbot
Copy link
Collaborator

rustbot commented Jul 13, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 13, 2025
@github-actions
Copy link

github-actions bot commented Jul 13, 2025 •
edited
Loading

Lintcheck changes for 1b88319

Lint Added Removed Changed
clippy::if_then_some_else_none 0 0 2

This comment will be updated if you push new changes

@profetia profetia marked this pull request as draft July 13, 2025 15:14
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 13, 2025
@blyxyas blyxyas added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Jul 13, 2025
blyxyas
blyxyas reviewed Jul 13, 2025
View reviewed changes
@profetia profetia force-pushed the issue15257 branch 3 times, most recently from bb83d44 to bafba95 Compare July 19, 2025 07:28
@profetia
Copy link
Contributor Author

profetia commented Jul 19, 2025

Using expr_requires_coercion adds too many FNs. This PR may stay in draft for a while.

@profetia
Copy link
Contributor Author

profetia commented Jul 19, 2025

Found a better way to solve this. This PR should be ready now.

@profetia profetia marked this pull request as ready for review July 19, 2025 11:34
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 19, 2025
@profetia profetia requested a review from blyxyas July 19, 2025 11:34
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Jul 19, 2025
blyxyas
blyxyas requested changes Jul 19, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jul 19, 2025
@profetia
Copy link
Contributor Author

profetia commented Jul 20, 2025

@blyxyas Updated. Thank you!

@profetia profetia requested a review from blyxyas July 20, 2025 05:13
blyxyas
blyxyas approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas blyxyas added this pull request to the merge queue Jul 24, 2025
Merged via the queue into rust-lang:master with commit 98205e6 Jul 24, 2025
11 checks passed
@profetia profetia deleted the issue15257 branch September 12, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels

S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

if-then-some-else-none changes return type

3 participants

@profetia @rustbot @blyxyas