similar_names stop linting for 3-char names

[honeyspoon]

fixes #14869

Added a simple check if both chars are of length 3
If they are, we skip the check for that pair.

This won't handle the 4 v 3 case.
Not sure if this was the intent of the issue.

Also saw we have some hardcoded exemptions for set, get and lhs, rhs
Tried removing them thinking they would be handled by the new condition.
But we have to keep because they allow for bla_lhs v bla_rhs to be skipped

changelog:[similar_names]: Stop triggering for 3-character names

[rustbot]

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[honeyspoon]

r? @lyxyas

[rustbot]

Failed to set assignee to lyxyas: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

[ada4a]

you probably meant blyxyas?

[honeyspoon]

sure or anybody that can review

[honeyspoon]

r? @blyxyas

[blyxyas]

Hi @honeyspoon, thanks for pinging me, I'll review it as soon as I have the time (I have some more reviews in queue and I'm currently writing a Project Goal).

Thanks for contributing!

[blyxyas]

LGTM, thanks! ❤️
Sorry for the slow review, and welcome to the project. Could you squish the 3 commits into one?

[github-actions]

Lintcheck changes for e41fb7c

Lint	Added	Removed	Changed
clippy::similar_names	0	48	5

This comment will be updated if you push new changes

[honeyspoon]

thanks I just squashed