Skip to content

Fix std_instead_of_core FP when part of the use cannot be replaced #15016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2025
Merged

Fix std_instead_of_core FP when part of the use cannot be replaced #15016

merged 1 commit into from
Jun 8, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jun 8, 2025 •
edited by llogiq
Loading

Closes #14982

changelog: [std_instead_of_core] fix FP when part of the use cannot be replaced

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 8, 2025
@llogiq
Copy link
Contributor

llogiq commented Jun 8, 2025

There's an inefficient_to_string triggered in dogfood. Otherwise this looks good.

@profetia
Copy link
Contributor Author

profetia commented Jun 8, 2025

@llogiq Fixed. Thank you!

@llogiq
Copy link
Contributor

llogiq commented Jun 8, 2025

Thank you!

@llogiq llogiq added this pull request to the merge queue Jun 8, 2025
Merged via the queue into rust-lang:master with commit 737b8be Jun 8, 2025
11 checks passed
@profetia profetia mentioned this pull request Jun 14, 2025
Closed
@profetia profetia mentioned this pull request Jun 28, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 1, 2025
@samueltardieu
Fix std-instead-of-core FP when not all items come from the new cra…
ad15b60 
…te (#15165)

Closes #15143

Covering edge cases missed in #15016

changelog: [`std-instead-of-core`] fix FP when not all items come from
the new crate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std-instead-of-core: there is no core::collections::*
3 participants
@profetia @rustbot @llogiq