Skip to content

fix: unnecessary_to_owned FP when map key is a reference #14834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

fix: unnecessary_to_owned FP when map key is a reference #14834

merged 1 commit into from
May 18, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented May 18, 2025 •
edited by rustbot
Loading

Closes #14833

changelog: [unnecessary_to_owned] fix FP when map key is a reference

@rustbot
Copy link
Collaborator

rustbot commented May 18, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 18, 2025
samueltardieu
samueltardieu reviewed May 18, 2025
View reviewed changes
samueltardieu
samueltardieu requested changes May 18, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is ok, but there is a possibility to avoid duplicating work.

@samueltardieu
Copy link
Member

r? @samueltardieu

@rustbot rustbot assigned samueltardieu and unassigned dswij May 18, 2025
@samueltardieu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 18, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@profetia
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels May 18, 2025
samueltardieu
samueltardieu approved these changes May 18, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@samueltardieu samueltardieu added this pull request to the merge queue May 18, 2025
Merged via the queue into rust-lang:master with commit 375c650 May 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@samueltardieu samueltardieu

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unnecessary_to_owned false positive when keying HashSet<&String>
4 participants
@profetia @rustbot @samueltardieu @dswij