Skip to content

Add necessary adjustments to suggestion to remove redundant .into_iter() calls #14035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
y21 merged 2 commits into from
Jan 23, 2025
Merged

Add necessary adjustments to suggestion to remove redundant .into_iter() calls #14035

y21 merged 2 commits into from
Jan 23, 2025

Conversation

@samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Jan 19, 2025

Fix #11819

changelog: [useless_conversion]: add necessary adjustments to suggestion to remove redundant .into_iter() calls

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 19, 2025
@samueltardieu samueltardieu force-pushed the push-kqmmsrlyuzvl branch 2 times, most recently from 78a5f08 to b5762a3 Compare January 19, 2025 20:37
@samueltardieu samueltardieu marked this pull request as draft January 19, 2025 20:42
@samueltardieu
Copy link
Member Author

samueltardieu commented Jan 19, 2025 •
edited
Loading

PR currently blocked by issue #14036, put to draft status
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jan 19, 2025
@samueltardieu samueltardieu marked this pull request as ready for review January 19, 2025 21:43
@samueltardieu
Copy link
Member Author

samueltardieu commented Jan 19, 2025

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jan 19, 2025
lapla-cogito
lapla-cogito reviewed Jan 20, 2025
View reviewed changes
y21
y21 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@y21 y21 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into rust-lang:master with commit 4b05f50 Jan 23, 2025
11 checks passed
@samueltardieu samueltardieu deleted the push-kqmmsrlyuzvl branch January 24, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@y21 y21 y21 approved these changes

+1 more reviewer

@lapla-cogito lapla-cogito lapla-cogito left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@y21 y21

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wrong hint about removing .into_iter() in zip

4 participants

@samueltardieu @rustbot @y21 @lapla-cogito