Skip to content

don't suggest to use cloned for Cow in unnecessary_to_owned #13853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
y21 merged 1 commit into from
Jan 12, 2025
Merged

don't suggest to use cloned for Cow in unnecessary_to_owned #13853

y21 merged 1 commit into from
Jan 12, 2025

Conversation

@lapla-cogito
Copy link
Contributor

@lapla-cogito lapla-cogito commented Dec 19, 2024 •
edited by y21
Loading

fix #13624

changelog: [unnecessary_to_owned]: don't suggest to use cloned on Cow in unnecessary_to_owned

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 19, 2024
@lapla-cogito lapla-cogito force-pushed the into_owned_cow branch 3 times, most recently from 461c834 to e0bf121 Compare December 19, 2024 13:40
@alex-semenyuk
Copy link
Member

alex-semenyuk commented Dec 20, 2024

@lapla-cogito Could you please take a look failed tests

y21
y21 reviewed Dec 21, 2024
View reviewed changes
@lapla-cogito lapla-cogito force-pushed the into_owned_cow branch 3 times, most recently from cbccedb to 9bcfac6 Compare December 27, 2024 12:04
@lapla-cogito lapla-cogito requested a review from y21 January 2, 2025 10:53
y21
y21 approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@y21 y21 enabled auto-merge January 12, 2025 21:26
@y21 y21 added this pull request to the merge queue Jan 12, 2025
Merged via the queue into rust-lang:master with commit 8f257c7 Jan 12, 2025
11 checks passed
@Hofer-Julian
Copy link

Hofer-Julian commented Jan 12, 2025

Thanks!

@notriddle notriddle mentioned this pull request Apr 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positive: cow and into_owned

5 participants

@lapla-cogito @rustbot @alex-semenyuk @Hofer-Julian @y21