Skip to content

Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows #13340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Sep 3, 2024

Bumps actions/download-artifact from 3 to 4.1.7.

Release notes

Sourced from actions/download-artifact's releases.

v4.1.7

What's Changed

Full Changelog: actions/download-artifact@v4.1.6...v4.1.7

v4.1.6

What's Changed

Full Changelog: actions/download-artifact@v4.1.5...v4.1.6

v4.1.5

What's Changed

Full Changelog: actions/download-artifact@v4.1.4...v4.1.5

v4.1.4

What's Changed

Full Changelog: actions/download-artifact@v4...v4.1.4

v4.1.3

What's Changed

New Contributors

Full Changelog: actions/download-artifact@v4...v4.1.3

v4.1.2

v4.1.1

v4.1.0

What's Changed

... (truncated)

Commits
  • 65a9edc Merge pull request #325 from bethanyj28/main
  • fdd1595 licensed
  • c13dba1 update @​actions/artifact dependency
  • 0daa75e Merge pull request #324 from actions/eggyhead/use-artifact-v2.1.6
  • 9c19ed7 Merge branch 'main' into eggyhead/use-artifact-v2.1.6
  • 3d3ea87 updating license
  • 89af5db updating artifact package v2.1.6
  • b4aefff Merge pull request #323 from actions/eggyhead/update-artifact-v215
  • 8caf195 package lock update
  • d7a2ec4 updating package version
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions labels Sep 3, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (NB. this repo may be misconfigured) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 3, 2024
@flip1995
Copy link
Member

flip1995 commented Sep 4, 2024

Huh, this kind of PR is new 👀 I didn't know that we had dependabot configured for the Clippy repo. Also why did rustbot try to assign Mark? It also auto-introduced 2 labels to the repo.

@Mark-Simulacrum Do you know where this is coming from? 🤔

@Mark-Simulacrum
Copy link
Member

It does look like dependabot is at least partially enabled - not sure whether that's recent or not. The assignment seems like it's probably because something temporarily (?) broke and triagebot failed to fetch the configuration for this repository...

@flip1995
Copy link
Member

flip1995 commented Sep 4, 2024

Hm, ok weird. Not really feeling like merging a dependabot PR. But the changes are good and I re-done them in #13343

@flip1995 flip1995 closed this Sep 4, 2024
Copy link
Author

dependabot bot commented on behalf of github Sep 4, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@flip1995 flip1995 deleted the dependabot/github_actions/dot-github/workflows/actions/download-artifact-4.1.7 branch September 4, 2024 16:19
@smoelius
Copy link
Contributor

smoelius commented Sep 5, 2024

Not really feeling like merging a dependabot PR.

@flip1995 Can I ask why?

@flip1995
Copy link
Member

flip1995 commented Sep 5, 2024

For one, the changes were incorrect and required some adaptation as I found out in #13343 . Other than that, we don't have dependabot set up for the repo. So merging one dependabot PR into the forever git history might be confusing.

And the PR description is quite spammy, which would've cause a spammy bors commit message. I don't know what happens with dependabot if I adapt the PR description. Also dependabot has it's own commands. I didn't want to find out what happens, when I let bors merge the PR.

TL;DR: I don't really want dependabot and don't want to find out what happens, if I accept this.

@smoelius
Copy link
Contributor

smoelius commented Sep 5, 2024

Thanks very much for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants